Page MenuHomePhabricator

SyntaxHighlight's background is a bit too expansive
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: The <pre> with its border stops at the content floating right. The surrounding <div> does not.

image.png (98×1 px, 17 KB)

What should have happened instead?: The background should stop.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This is due to the various background CSS currently targeting div.mw-highlight. There's presently two blocks of it that will need to be removed, one of which is created by updateCSS.php. (Maybe one after T365774.)

Event Timeline

matmarex subscribed.

I noticed this too when making some changes to API documentation pages on mw.org, e.g. https://www.mediawiki.org/wiki/API:Login#Example

image.png (842×3 px, 216 KB)

Test page for convenience: https://www.mediawiki.org/wiki/User:Matma_Rex/T365927

Change #1068844 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Fix forced light mode background-color applied to the wrong element

https://gerrit.wikimedia.org/r/1068844

Change #1068844 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Fix forced light mode background-color applied to the wrong element

https://gerrit.wikimedia.org/r/1068844