Maniphest T366175

[Generalised error] Invalid query parameter
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Ifrahkhanyaree_WMDE
	Wed, May 29, 1:14 PM

Tags

Referenced Files

None

Subscribers

Ifrahkhanyaree_WMDE

Description

Acceptance criteria:

Current messages it will replace: Invalid value for _fields or property for GET /items GET /properties and GET /statements endpoints
HTTP status code: 400
Error code: invalid-query-parameter
Error message: Invalid query parameter: '{parameter}'
Context: "parameter": "{matching query parameter in the OpenAPI spec}"

Details

	Subject	Repo	Branch	Lines +/-
	REST: Generalise 'invalid-query-parameter' error	mediawiki/extensions/Wikibase	master	+75 -67

Customize query in gerrit

Related Objects

Mentioned In: T368398: [MAIN] REST API v1 CHECKLIST

Event Timeline

Ifrahkhanyaree_WMDE created this task.Wed, May 29, 1:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 29, 1:14 PM

Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.Wed, Jun 5, 11:02 AM

Ifrahkhanyaree_WMDE renamed this task from [Generalised error] Incorrect query parameter to [Generalised error] Invalid query parameter.Wed, Jun 5, 11:05 AM

Ifrahkhanyaree_WMDE updated the task description. (Show Details)

WMDE-leszek updated the task description. (Show Details)Thu, Jun 6, 10:30 AM

WMDE-leszek updated the task description. (Show Details)Thu, Jun 6, 10:33 AM

WMDE-leszek set the point value for this task to 3.Thu, Jun 6, 10:35 AM

Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.Fri, Jun 7, 9:20 AM

Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 22 on the Wikibase Product Platform Team WPP board.Tue, Jun 11, 9:55 AM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 22); removed Wikibase Product Platform Team WPP.

Task breakdown notes:

respond with the new errors for _fields (item), _fields (property)
- adjust the corresponding deserializing request validators to throw the new kinds of UseCaseErrors
- adjust the examples in the spec
respond with the new error for property (statements list)
- adjust the examples in the spec
- this currently reuses the same validator as property ID path parameters but now needs a separate validator since the error is different

Silvan_WMDE claimed this task.Wed, Jun 19, 7:34 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 22) board.

Change #1047908 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Generalise 'invalid-query-parameter' error

https://gerrit.wikimedia.org/r/1047908

gerritbot added a project: Patch-For-Review.Thu, Jun 20, 8:05 AM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 22) board.Thu, Jun 20, 9:22 AM

Change #1047908 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Generalise 'invalid-query-parameter' error

https://gerrit.wikimedia.org/r/1047908

Maintenance_bot removed a project: Patch-For-Review.Sat, Jun 22, 2:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Sat, Jun 22, 3:00 PM

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 22) board.Sun, Jun 23, 12:55 PM

Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Jun 25, 10:08 AM

Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Tue, Jun 25, 1:13 PM

Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Wed, Jun 26, 5:13 PM