Page MenuHomePhabricator

Disable MW responsive infobox styles on pl.wikipedia
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Remove style like body.skin--responsive .mw-parser-output .infobox styles on plwikipedia.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Wanted to move styles to a default gadget, but MW core seems to be fighting with me for browser attention ;)
https://pl.wikipedia.org/wiki/MediaWiki:Gadget-infobox.css

Benefits (why should this be implemented?):
Less bytes downloaded. Good for all users.

Won't have to fight with core styles. Less work for style maintainers.

Styles I had to disable:

/* load.php | https://pl.m.wikipedia.org/w/load.php?lang=pl&modules=codex-styles%7Cext.cite.styles%7Cext.echo.styles.badge%7Cext.flaggedRevs.basic%2Cicons%7Cext.growthExperiments.mobileMenu.icons%7Cext.relatedArticles.styles%7Cext.wikimediaBadges%7Cext.wikimediamessages.styles%7Cmediawiki.hlist%7Cmobile.init.styles%7Coojs-ui.styles.icons-alerts%7Cskins.minerva.amc.styles%7Cskins.minerva.base.styles%7Cskins.minerva.categories.styles%7Cskins.minerva.codex.styles%7Cskins.minerva.content.styles.images%7Cskins.minerva.icons.wikimedia%7Cskins.minerva.loggedin.styles%7Cskins.minerva.mainMenu.advanced.icons%7Cskins.minerva.mainMenu.icons%2Cstyles%7Cskins.minerva.overflow.icons%7Cskins.minerva.personalMenu.icons%7Cwikibase.client.init&only=styles&skin=minerva */

body.skin--responsive .mw-parser-output .infobox {
  /* float: none !important; */
  /* margin-left: 0 !important; */
  /* margin-right: 0 !important; */
  /* font-size: 90%; */
  /* position: relative; */
  /* border: 1px solid var(--border-color-muted,#eaecf0); */
  /* margin-bottom: 2em; */
  /* color: var(--color-base,#202122); */
  /* background-color: var(--background-color-interactive-subtle,#f8f9fa); */
  /* display: flex; */
  /* flex: 1 1 100%; */
  /* flex-flow: column nowrap; */
  /* width: 100% !important; */
  /* max-width: 100% !important; */
}

@media (min-width: 720px) {
  body.skin--responsive .mw-parser-output .infobox {
    /* margin: 0.5em 0 1em 35px !important; */
    /* max-width: 320px !important; */
    /* width: auto !important; */
    /* float: right !important; */
    /* clear: right !important; */
  }
}

body.skin--responsive .mw-parser-output .infobox > tbody > tr {
  /* min-width: 100%; */
  /* display: flex; */
  /* flex-flow: row nowrap; */
}

body.skin--responsive .mw-parser-output .infobox > tbody, body.skin--responsive .mw-parser-output .infobox > caption {
  /* display: flex; */
  /* flex-flow: column nowrap; */
}

body.skin--responsive .mw-parser-output .infobox th, body.skin--responsive .mw-parser-output .infobox td {
  /* vertical-align: top; */
  /* border: 0; */
  /* border-bottom: 1px solid var(--border-color-muted,#eaecf0); */
  /* padding: 7px 10px; */
}

Event Timeline

An example article (notice how borders are not collapsing)

This is how it looks like now:

obraz.png (1×857 px, 92 KB)

This is how it supposed to look:

obraz.png (1×857 px, 111 KB)

Side note: with https://pl.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=73889807&oldid=73887321 and directly removing the code from mobile.css in https://pl.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&diff=prev&oldid=73890354 you will probably be running into caching issues for anons like in T362747, so maybe it makes sense to postpone opting out of the global styles until the cache has cleared.

Nux claimed this task.

Thanks! And thanks for the warning too :-)

Waiting for styles to kick in, but it looks good in debug already :-)
https://pl.m.wikipedia.org/wiki/Dewon?debug=2