Page MenuHomePhabricator

Investigate & resolve inaccurate usage of LoginSignupSpecialPage::getReturnToQueryStringFragment()
Closed, ResolvedPublic

Description

While working on T362713: Implement the new login process which redirects to the central login wiki for showing the login/signup form, it was noticed that LoginSignupSpecialPage::getReturnToQueryStringFragment() is used in some places where ::getPreservedParams() should be used instead.

Code in the LoginSignupSpecialPage class and possibly other places should be refactored to use getReturnToQueryStringFragment() and/or getPreservedParams() in the correct places so that extensions such as CentralAuth can hook into that code or code calling those methods to preserve the query params when authentication process is happening.

The goal of this is for extensions to be able to make use of query params (GET params) during the authentication workflow between wikis.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr moved this task from Soon to Current Sprint on the MediaWiki-Platform-Team board.
Tgr moved this task from Backlog to In progress on the SUL3 board.

Change #1051088 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Unify query parameter preserving auth special page methods

https://gerrit.wikimedia.org/r/1051088

Change #1051088 merged by jenkins-bot:

[mediawiki/core@master] Unify query parameter preserving auth special page methods

https://gerrit.wikimedia.org/r/1051088

Looks like we can resolve this. Thanks @Tgr! 💥