Page MenuHomePhabricator

AutoModerator should perform prechecks in RevisionFromEditCompleteHookHandler before queuing job
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR

Description

There are various cases where AutoModeratorFetchRevScore will error out, such as page moves and redirects. I noticed errors on testwiki from redirect revisions (mw-new-redirect). We check for this tag in the precheck running inside the job, but the job errors out before the precheck runs. It would be a performance optimization to run prechecks before queing the job where possible anyway since this would result in an earlier exit.

Error
normalized_message
Failed executing job: AutoModeratorFetchRevScoreJob Ebernhardson_move_test wikiPageId=156158 revId=597386 originalRevId= userId=23626 userName=EBernhardson (WMF) tags=["mw-new-redirect"] namespace=0 title=Ebernhardson_move_test requestId=f245d58f-9c6d-47e
exception.trace
Impact
Notes

Details

Event Timeline

jsn.sherman created this task.

Change #1041637 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] AutoModerator should perform prechecks in RevisionFromEditCompleteHookHandler before queuing job

https://gerrit.wikimedia.org/r/1041637

Change #1041637 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] AutoModerator should perform prechecks in RevisionFromEditCompleteHookHandler before queuing job

https://gerrit.wikimedia.org/r/1041637

jsn.sherman renamed this task from AutoModerator should perform many prechecks in RevisionFromEditCompleteHookHandler before queuing job to AutoModerator should perform prechecks in RevisionFromEditCompleteHookHandler before queuing job.Fri, Jun 14, 12:43 AM
jsn.sherman changed the task status from Open to In Progress.
jsn.sherman added a project: Automoderator.