PagedTiffHandler phpunit failure on TimingMetric
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Mon, Jun 10, 6:37 PM

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/17949/console

1) PagedTiffHandlerTest::testDoTransformLarge
Stats: stop() called before start() for metric 'media_thumbnail_generate_transform_seconds'

/workspace/src/includes/libs/Stats/Metrics/TimingMetric.php:80
/workspace/src/includes/filerepo/file/File.php:1331
/workspace/src/includes/filerepo/file/File.php:1271
/workspace/src/extensions/PagedTiffHandler/tests/phpunit/PagedTiffHandlerTest.php:182
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

The test calls File::transform and ends with this exception

Details

	Subject	Repo	Branch	Lines +/-
	File: handle stats for recursive transformation calls	mediawiki/core	master	+9 -4

Customize query in gerrit

Related Objects

Mentioned In: T368073: TimingMetric and recursion edge case
Mentioned Here: rMWe6b5823b46be: Migrate File to statslib
T359344: Migrate MediaWiki.media.thumbnail.* to statslib

Event Timeline

Umherirrender created this task.Mon, Jun 10, 6:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Jun 10, 6:37 PM

There is a recursive call and TimingMetric does not stack its calls. Not sure if this only happens in test or also in production depending on config.

PagedTiffHandlerTest->testDoTransformLarge
=> File->transform
=> File->generateAndSaveThumb
=> Wikimedia\Stats\Metrics\TimingMetric->start
[...]
PagedTiffHandlerTest->testDoTransformLarge
=> File->transform
=> File->generateAndSaveThumb
=> TransformationalImageHandler->doTransform
=> MediaWiki\Extension\PagedTiffHandler\PagedTiffHandler->getThumbnailSource
=> MediaWiki\Extension\PagedTiffHandler\PagedTiffHandler->getIntermediaryStep
=> File->transform
=> File->generateAndSaveThumb
=> Wikimedia\Stats\Metrics\TimingMetric->start
[...]
PagedTiffHandlerTest->testDoTransformLarge
=> File->transform
=> File->generateAndSaveThumb
=> TransformationalImageHandler->doTransform
=> MediaWiki\Extension\PagedTiffHandler\PagedTiffHandler->getThumbnailSource
=> MediaWiki\Extension\PagedTiffHandler\PagedTiffHandler->getIntermediaryStep
=> File->transform
=> File->generateAndSaveThumb
=> Wikimedia\Stats\Metrics\TimingMetric->stop
[...]
PagedTiffHandlerTest->testDoTransformLarge
=> File->transform
=> File->generateAndSaveThumb
=> Wikimedia\Stats\Metrics\TimingMetric->stop ----> Failure

Umherirrender unsubscribed.Tue, Jun 18, 7:00 PM

Maintenance_bot added a project: Commons.Tue, Jun 18, 7:30 PM

Umherirrender closed this task as a duplicate of T367928: TimingMetric warning on File: page after uploading video file.Wed, Jun 19, 5:46 PM

Change #1048020 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] File: handle stats for recursive transformation calls

https://gerrit.wikimedia.org/r/1048020

gerritbot added a project: Patch-For-Review.Thu, Jun 20, 3:03 PM

colewhite mentioned this in T368073: TimingMetric and recursion edge case.Thu, Jun 20, 3:24 PM

Change #1048020 merged by jenkins-bot:

[mediawiki/core@master] File: handle stats for recursive transformation calls

https://gerrit.wikimedia.org/r/1048020

Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 20, 9:30 PM