http.get_authentication() uses private requests.util.urlparse() function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Sun, Jun 16, 5:04 AM

Description

comms.http.get_authentication() uses requests.util.urlparse() function which is not member of the public API. urllib.parse.urlparse
should be used instead.

Details

	Subject	Repo	Branch	Lines +/-
	[IMPR] replace requests.utils.urlparse with urllib.parse.urlparse	pywikibot/core	master	+10 -11

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Feature	None	T57889 Improve support for asynchronous requests (saving/preloading pages)
Open	Feature	None	T314121 Provide parallel processing of the BaseBot generator property
Open	Feature	None	T334053 Use only one entry point for all http requests
Resolved		Xqt	T367649 http.get_authentication() uses private requests.util.urlparse() function

Event Timeline

Xqt created this task.Sun, Jun 16, 5:04 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSun, Jun 16, 5:04 AM

Xqt triaged this task as Low priority.Sun, Jun 16, 5:04 AM

Xqt added a parent task: T334053: Use only one entry point for all http requests.

Xqt updated the task description. (Show Details)

Change #1045496 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] replace requests.utils.urlparse with urllib.parse.urlparse

https://gerrit.wikimedia.org/r/1045496

gerritbot added a project: Patch-For-Review.Sun, Jun 16, 5:06 AM

Xqt closed this task as Resolved.Sun, Jun 16, 5:15 AM

Change #1045496 merged by jenkins-bot: