Page MenuHomePhabricator

http.get_authentication() uses private requests.util.urlparse() function
Closed, ResolvedPublic

Description

comms.http.get_authentication() uses requests.util.urlparse() function which is not member of the public API. urllib.parse.urlparse
should be used instead.

See also: see https://github.com/psf/requests/blob/eedd67462819f8dbf8c1c32e77f9070606605231/requests/compat.py#L58

Event Timeline

Xqt triaged this task as Low priority.Jun 16 2024, 5:04 AM
Xqt updated the task description. (Show Details)

Change #1045496 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] replace requests.utils.urlparse with urllib.parse.urlparse

https://gerrit.wikimedia.org/r/1045496

Change #1045496 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] replace requests.utils.urlparse with urllib.parse.urlparse

https://gerrit.wikimedia.org/r/1045496