Page MenuHomePhabricator
Create Task
Maniphest T367827

Special:AllMessages highlights columns with yellow/green and this is not accessible in dark mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jun 17 2024, 10:18 PM
Project Tags
Referenced Files
F56336874: 2024-07-10_11-07-41.png
Jul 10 2024, 6:10 PM
F56203633: Screenshot 2024-07-03 at 11.16.11 AM.png
Jul 3 2024, 4:18 PM
F55350596: screenshot 80.png
Jun 17 2024, 10:18 PM
File Not Attached
Subscribers
Aklapper
Ebrahim
GMikesell-WMF
Jdlrobson
KSarabia-WMF

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Color contrast issues due to hardcoded non-standard design tokens in https://gerrit.wikimedia.org/g/mediawiki/core/+/adf0beeaabc7ded0c450abc1000a92eaeb355d16/resources/src/mediawiki.special/special.less#14

screenshot 80.png (1,297×1,064 px, 276 KB)

What should have happened instead?:
No color contrast issues

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - PROD

ACStatusDetails
1✅pass per T367827#9970990

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Special:AllMessage colors in dark modemediawiki/coremaster+41 -1
Special:AllMessages: Make colors compatible with dark modemediawiki/coremaster+11 -23
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 17 2024, 10:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2024, 10:18 PM
Jdlrobson updated the task description. (Show Details)Jun 17 2024, 10:18 PM
Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .
Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.
Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.Jun 18 2024, 3:59 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Jun 26 2024, 7:01 PM

Non-standard token - will need a dark mode override or a token.

Jdlrobson moved this task from Incoming to FY2024-25 Q1 Sprint 1 on the Web-Team-Backlog-Archived board.Jun 26 2024, 8:09 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1); removed: Web-Team-Backlog-Archived.
Jdlrobson added a project: patch-welcome.Jun 26 2024, 11:03 PM
ovasileva triaged this task as Medium priority.Jun 27 2024, 3:11 PM
Jdlrobson added a project: dark-mode.Jun 28 2024, 2:30 AM
Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jun 28 2024, 3:03 AM
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.Jun 28 2024, 8:08 PM
Jdlrobson raised the priority of this task from Medium to High.Jul 1 2024, 4:45 PM
Jdlrobson added a subscriber: Ebrahim.Jul 1 2024, 4:49 PM

I suggest using the background success color for these, as @Ebrahim did in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/1050668

ovasileva set the point value for this task to 1.Jul 1 2024, 5:49 PM
ovasileva moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
gerritbot added a comment.Jul 1 2024, 7:13 PM

Change #1051190 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Make Special:AllMessages compatible with dark mode

https://gerrit.wikimedia.org/r/1051190

gerritbot added a project: Patch-For-Review.Jul 1 2024, 7:13 PM
gerritbot added a comment.Jul 1 2024, 9:03 PM

Change #1051203 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/core@master] Update Special:AllMessage colors

https://gerrit.wikimedia.org/r/1051203

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.Jul 1 2024, 10:41 PM
gerritbot added a comment.Jul 1 2024, 11:12 PM

Change #1051190 merged by jenkins-bot:

[mediawiki/core@master] Special:AllMessages: Make colors compatible with dark mode

https://gerrit.wikimedia.org/r/1051190

Jdlrobson assigned this task to GMikesell-WMF.Jul 1 2024, 11:26 PM
Jdlrobson lowered the priority of this task from High to Low.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jul 2 2024, 12:00 AM
gerritbot added a comment.Jul 2 2024, 3:21 PM

Change #1051203 abandoned by Bernard Wang:

[mediawiki/core@master] Update Special:AllMessage colors in dark mode

Reason:

https://gerrit.wikimedia.org/r/1051203

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2024, 3:31 PM
KSarabia-WMF claimed this task.Jul 2 2024, 8:38 PM
KSarabia-WMF added a subscriber: GMikesell-WMF.
KSarabia-WMF added a comment.Jul 3 2024, 4:18 PM

Test Result - Beta
Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

  1. https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllMessages
  2. Check the unreadable text
  3. It is now passing WCAG color contrast requirements

Screenshot 2024-07-03 at 11.16.11 AM.png (2,006×704 px, 242 KB)

KSarabia-WMF reassigned this task from KSarabia-WMF to ovasileva.Jul 3 2024, 4:18 PM
KSarabia-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.
KSarabia-WMF subscribed.
GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM
ovasileva closed this task as Resolved.Jul 8 2024, 10:35 AM
GMikesell-WMF added a comment.EditedJul 10 2024, 6:10 PM

@Jdlrobson Please review WCAG color issue, thanks!

Test Result - PROD

Status: ❌ FAIL
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. https://en.wikipedia.org/wiki/Special:AllMessages?vectornightmode=1
  2. Check the unreadable text
  3. It is now passing WCAG color contrast requirements
WCAG color contrast failed
2024-07-10_11-07-41.png (3,172×418 px, 178 KB)
GMikesell-WMF updated the task description. (Show Details)Jul 10 2024, 6:12 PM
Jdlrobson added a project: Verified.Jul 10 2024, 7:15 PM

That bug is tracked in T368789. We can mark this as verified!

Jdlrobson mentioned this in T368789: Diff colors in dark mode are not accessible.Jul 10 2024, 7:15 PM
GMikesell-WMF updated the task description. (Show Details)Jul 10 2024, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits