Page MenuHomePhabricator

[Spike] QA outcome of OOUI work
Closed, ResolvedPublic

Assigned To
Authored By
ovasileva
May 20 2024, 5:32 PM
Referenced Files
F55350924: screenshot 109.png
Sat, Jun 15, 5:49 PM
F55350923: screenshot 105.png
Sat, Jun 15, 5:49 PM
F55350922: screenshot 108.png
Sat, Jun 15, 5:49 PM
F55350921: screenshot 106.png
Sat, Jun 15, 5:49 PM
F55350920: screenshot 107.png
Sat, Jun 15, 5:49 PM
F55350910: screenshot 104.png
Sat, Jun 15, 5:49 PM
F55350909: screenshot 102.png
Sat, Jun 15, 5:49 PM
F55350908: screenshot 103.png
Sat, Jun 15, 5:49 PM

Description

Background

T363857: [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens and T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens will be completed this week. Web team should review outcome and determine next step, and create subsequent tickets

QA

On beta cluster, review the following pages/features on the beta cluster and note any remaining issues in dark mode with color contrast:

  • VisualEditor
  • Talk pages
  • Recent changes
  • Special:Homepage

...

Please reassess the following bugs after the change and note any regressions in behaviour:

Also reassess the following tests from T363780 [AC2, AC5 and AC15]:

screenshot 443.png (1×1 px, 897 KB)

screenshot 444.png (1×1 px, 841 KB)

screenshot 405.png (1×1 px, 307 KB)

Reassess the special pages listed in T366373 using data tables on test wiki for color contrast issues:

Related Objects

Event Timeline

Jdlrobson renamed this task from [Spike] Review outcome of OOUI work to [Spike] QA outcome of OOUI work .May 21 2024, 4:14 PM
Jdlrobson updated the task description. (Show Details)
Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: Beta and testwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify QA outcome of OOUI work

  1. AC1: On beta cluster, review the following pages/features on the beta cluster and note any remaining issues in dark mode with color contrast:
    • ❌ VisualEditor
LightDark
screenshot 11.png (873×1 px, 149 KB)
screenshot 12.png (880×1 px, 251 KB)
screenshot 15.png (880×1 px, 161 KB)
screenshot 20.png (880×1 px, 164 KB)
screenshot 14.png (880×1 px, 185 KB)
screenshot 13.png (880×1 px, 170 KB)
screenshot 10.png (880×1 px, 269 KB)
screenshot 16.png (880×1 px, 173 KB)
screenshot 17.png (880×1 px, 178 KB)
screenshot 19.png (880×1 px, 195 KB)
  • ❌Talk pages
LightDark
screenshot 22.png (880×1 px, 212 KB)
screenshot 24.png (880×1 px, 267 KB)
screenshot 26.png (1×1 px, 251 KB)
screenshot 28.png (1×1 px, 329 KB)
screenshot 30.png (1×1 px, 319 KB)
screenshot 32.png (1×1 px, 330 KB)
screenshot 23.png (880×1 px, 227 KB)
screenshot 25.png (880×1 px, 228 KB)
screenshot 27.png (1×1 px, 271 KB)
screenshot 29.png (1×1 px, 274 KB)
screenshot 31.png (1×1 px, 265 KB)
screenshot 33.png (1×1 px, 278 KB)
  • ❌Recent changes
LightDark
screenshot 34.png (1×1 px, 344 KB)
screenshot 36.png (1×1 px, 340 KB)
screenshot 35.png (1×1 px, 321 KB)
screenshot 37.png (1×1 px, 299 KB)
  • ❌Special:Homepage
LightDark
screenshot 39.png (1×1 px, 256 KB)
screenshot 40.png (1×1 px, 198 KB)
  1. ❌⬜ AC2: Please reassess the following bugs after the change and note any regressions in behaviour: T365050
LightDark
screenshot 41.png (1×1 px, 412 KB)
screenshot 42.png (1×1 px, 462 KB)
  1. AC3: Also reassess the following tests from T363780 [AC2, AC5 and AC15]:

T363780:AC2

LightDark
screenshot 43.png (1×1 px, 221 KB)
screenshot 45.png (1×1 px, 215 KB)
screenshot 47.png (1×1 px, 232 KB)
screenshot 49.png (1×1 px, 202 KB)
screenshot 51.png (1×1 px, 130 KB)
screenshot 53.png (1×1 px, 289 KB)
screenshot 55.png (1×1 px, 220 KB)
screenshot 57.png (1×1 px, 217 KB)
screenshot 59.png (1×1 px, 218 KB)
screenshot 61.png (1×1 px, 247 KB)
screenshot 63.png (1×1 px, 215 KB)
screenshot 44.png (1×1 px, 178 KB)
screenshot 46.png (1×1 px, 174 KB)
screenshot 48.png (1×1 px, 171 KB)
screenshot 50.png (1×1 px, 287 KB)
screenshot 52.png (1×1 px, 213 KB)
screenshot 54.png (1×1 px, 230 KB)
screenshot 56.png (1×1 px, 163 KB)
screenshot 58.png (1×1 px, 161 KB)
screenshot 60.png (1×1 px, 162 KB)
screenshot 62.png (1×1 px, 190 KB)
screenshot 64.png (1×1 px, 159 KB)

T363780:AC5
This fails WCAG in light mode as well.

LightDark
screenshot 67.png (1×1 px, 410 KB)
screenshot 68.png (1×1 px, 412 KB)
screenshot 65.png (1×1 px, 393 KB)
screenshot 66.png (1×1 px, 391 KB)

T363780:AC15

LightDark
screenshot 69.png (1×1 px, 161 KB)
screenshot 70.png (1×1 px, 236 KB)
  1. AC4: Repeat tests on T366197

See the Visual Editor screenshots in AC1.

LightDark
screenshot 71.png (1×1 px, 131 KB)
screenshot 72.png (1×1 px, 192 KB)
  1. ✅❓❌⬜ AC5: Reassess the special pages listed in T366373 using data tables on test wiki for color contrast issues:

Note: Some of these failures are related to the table pagination links outside of the tables.

  1. ✅❓❌⬜ AC6: Repeat test on https://test.wikipedia.org/wiki/Special:MathStatus
LightDark
screenshot 89.png (1×1 px, 244 KB)
screenshot 88.png (1×1 px, 256 KB)
  1. ❓ ⬜ AC7: Check preferences pages (T366378)

Most of these also fail WCAG in light mode.

LightDark
screenshot 100.png (1×1 px, 243 KB)
screenshot 99.png (1×1 px, 256 KB)
screenshot 94.png (1×1 px, 246 KB)
screenshot 93.png (1×1 px, 258 KB)
LightDark
screenshot 95.png (1×1 px, 238 KB)
screenshot 96.png (1×1 px, 244 KB)
screenshot 98.png (1×1 px, 239 KB)
screenshot 97.png (1×1 px, 244 KB)
  • ❓ When I perform a search for preferences, it is possible highlights are legible:
LightDark
screenshot 103.png (1×1 px, 196 KB)
screenshot 102.png (1×1 px, 198 KB)
screenshot 104.png (1×1 px, 233 KB)
screenshot 107.png (1×1 px, 197 KB)
screenshot 106.png (1×1 px, 198 KB)
screenshot 108.png (1×1 px, 234 KB)
screenshot 105.png (1×1 px, 197 KB)
screenshot 109.png (1×1 px, 227 KB)
Jdlrobson added a subscriber: GMikesell-WMF.

cc @ovasileva - I ran through all the test failures and created tickets for newly identified work and updated existing tickets with new test cases.

  • ❌Talk pages
  1. AC4: Repeat tests on T366197

Tracked in T366197 and T367432

  • ❌Recent changes

There was an issue on wiki which I fixed. I noted the other issue in T366371 as a sign off step, as it looks like T366197 will fix this.

  • ❌Special:Homepage

All of this is captured in T357699.

  1. ❌⬜ AC2: Please reassess the following bugs after the change and note any regressions in behaviour: T365050

I opened T367822 for this issue.

T363780:AC15

Tracked in T367824.

  1. AC3: Also reassess the following tests from T363780 [AC2, AC5 and AC15]:

Updated test cases on T367813 which should fix these issues.

Tracked in T367827.

Issue with table text is tracked in T367826.

I can't replicate the issue with the pager icons on beta cluster: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:ListFiles
@GMikesell-WMF can you?
I think these fixes should therefore be on this week's train.

  1. ✅❓❌⬜ AC6: Repeat test on https://test.wikipedia.org/wiki/Special:MathStatus

Updated T367581.

  1. ❓ ⬜ AC7: Check preferences pages (T366378)

All of these issues are permitted per WCAG as they are for disabled interface elements.