[Config change] Enable night theme on preferences pages
Open, MediumPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Fri, May 31, 4:34 PM

Description

NOTE: The earliest this can be backported in June 20th, when https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1041782 is in production

Background

As a user I want night them on all pages.

User story

As a user I want all my pages in dark mode.

Acceptance criteria

When I visit https://en.wikipedia.org/w/index.php?title=Special:GlobalPreferences there are no color contrast issues and no illegible icons
When I visit https://en.wikipedia.org/w/index.php?title=Special:Preferences there are no color contrast issues and no illegible icons
When I perform a search for preferences, it is possible highlights are legible:

Screenshot 2024-06-12 at 2.22.59 PM.png (432×745 px, 66 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Enable dark mode on more pages	operations/mediawiki-config	master	+9 -20
	Preferences: Replace static color values with Codex tokens enabling dark mode	mediawiki/core	master	+13 -13

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		None	T367150 Deploy dark mode to logged-out users on the Vector2022 skin
Open		Jdlrobson	T366378 [Config change] Enable night theme on preferences pages
Open		None	T364777 [EPIC] Enable dark mode in OOUI
Declined	Feature	egardner	T363849 [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens
Duplicate		None	T364420 QA Editing-related night mode changes (desktop)
Open		EAkinloose	T360691 QA Editing-related OOUI updates (mobile + desktop)
Duplicate	BUG REPORT	None	T365517 PopupWidget notification for hidden sidebars has white background
Declined	Feature	egardner	T363857 [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens
Duplicate		CCiufo-WMF	T365521 QA Editing-related REM changes
Open		ovasileva	T365764 [OOUI] Icons: Add support for use in dark mode
Resolved		NBaca-WMF	T366709 [Spike] Make a decision on what needs to happen for icons before the new OOUI release
Declined		Volker_E	T366101 [OOUI] Fix font size inconsistencies across skins with `rem` based sizing
Open		None	T366708 QA Web/Reading-related OOUI updates (mobile + desktop)
Open		Volker_E	T367095 OOUI dark mode bug fixes post-0.50.0 release
Open		Edtadros	T367375 Search page doesn't work in dark mode

Event Timeline

Jdlrobson created this task.Fri, May 31, 4:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 31, 4:34 PM

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.Fri, May 31, 4:46 PM

Jdlrobson triaged this task as High priority.Fri, May 31, 4:49 PM

Hopefully will be fixed by T365383

Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .Fri, May 31, 4:57 PM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Fri, May 31, 5:02 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:44 AM

Jdlrobson added a subtask: T364777: [EPIC] Enable dark mode in OOUI.Mon, Jun 3, 10:51 PM

Change #1042214 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/core@master] styles: Replace static color values with Codex tokens enabling dark mode

https://gerrit.wikimedia.org/r/1042214

gerritbot added a project: Patch-For-Review.Wed, Jun 12, 3:28 PM

Jdlrobson updated the task description. (Show Details)Wed, Jun 12, 9:23 PM

Jdlrobson updated the task description. (Show Details)

Change #1042214 merged by jenkins-bot:

[mediawiki/core@master] Preferences: Replace static color values with Codex tokens enabling dark mode

https://gerrit.wikimedia.org/r/1042214

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Wed, Jun 12, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, Jun 12, 10:30 PM

All that remains is an update to configuration.
The earliest this can be deployed is the 20th.

Jdlrobson renamed this task from Enable night theme on preferences pages to [Config change] Enable night theme on preferences pages.Wed, Jun 12, 11:29 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 1.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog.Thu, Jun 13, 12:12 AM

Jdlrobson moved this task from Needs analysis to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Change #1042431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1042431

gerritbot added a project: Patch-For-Review.Thu, Jun 13, 12:25 AM

ovasileva added a parent task: T367150: Deploy dark mode to logged-out users on the Vector2022 skin.Mon, Jun 17, 12:41 PM

ovasileva lowered the priority of this task from High to Medium.Thu, Jun 20, 4:55 PM

NBaca-WMF moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 4:56 PM

Scheduling for Monday.

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 6:10 PM

	F55270390: Screenshot 2024-06-12 at 2.22.59 PM.png
	Wed, Jun 12, 9:23 PM

[Config change] Enable night theme on preferences pagesOpen, MediumPublic1 Estimated Story PointsActions