OOUI dark mode bug fixes post-0.50.0 release
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	AnneT
	Jun 10 2024, 5:20 PM

Description

Background

We've limited impactful changes in OOUI v0.50.0 solely to enabling dark mode. Nonetheless we're assuming to catch a number of dark mode related issues in OOUI interfaces.
This task is a catch-all for issues and fixes for them.

Goal

Ensure that OOUI interfaces are navigable and readable in dark mode

Issues

Special:Preferences OOUI stylesheet uses hard-coded values resulting for example in

Special:ApiSandbox

Primary destructive buttons use dark color instead of white

Radio buttons active state disc is dark instead of white
~~Focus ring on Radios and focus outline on Checkboxes is dark instead of white~~ Comparison with Codex and more thought have resulted in the focus outline to behave like light mode. The black inner is representing the page background color and is therefore correct.

Acceptance criteria

Fix all captured dark mode related issues
- 1. Special:Preferences
- 2. Special:ApiSandbox
- 3. OOUI primary buttons – https://gerrit.wikimedia.org/r/c/oojs/ui/+/1043136
- 4. OOUI Radio buttons state
- 5. OOUI Button framed active state

Details

Subject	Repo	Branch	Lines +/-
WikimediaUI theme: Fix dark mode contrast for framed active button element	oojs/ui	master	+1 -1
WikimediaUI theme: Fix radio disc color in dark mode	oojs/ui	master	+3 -3
apisandbox, styles: Apply dark mode enabled color tokens	mediawiki/core	master	+3 -3
WikimediaUI theme: Fix primary button color in dark mode	oojs/ui	master	+8 -8
Preferences: Replace static color values with Codex tokens enabling dark mode	mediawiki/core	master	+13 -13

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Volker_E	T367095 OOUI dark mode bug fixes post-0.50.0 release
		Resolved		ovasileva	T367375 Search page doesn't work in dark mode

Event Timeline

AnneT created this task.Jun 10 2024, 5:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2024, 5:20 PM

AnneT triaged this task as High priority.Jun 10 2024, 5:21 PM

AnneT set the point value for this task to 5.

AnneT added a project: Design-System-Team.

AnneT moved this task from Inbox to DST-Sprint-25 (2024-06-10 to 2024-06-21) on the Design-System-Team board.

AnneT edited projects, added Design-System-Team (DST-Sprint-25 (2024-06-10 to 2024-06-21)); removed Design-System-Team.

Volker_E renamed this task from [PLACEHOLDER] OOUI bug fixes post-0.50.0 release to OOUI dark mode bug fixes post-0.50.0 release.Jun 12 2024, 11:45 AM

Volker_E updated the task description. (Show Details)

Change #1042214 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] styles: Replace static color values with Codex tokens enabling dark mode

https://gerrit.wikimedia.org/r/1042214

gerritbot added a project: Patch-For-Review.Jun 12 2024, 11:50 AM

Change #1042247 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Enable dark mode

https://gerrit.wikimedia.org/r/1042247

thiemowmde added a project: WMDE-TechWish-Sprint-2024-06-12.Jun 12 2024, 1:37 PM

thiemowmde moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-06-12 board.

thiemowmde added subscribers: thiemowmde, Lina_Farid_WMDE, WMDE-Fisch.

Change #1042262 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] apisandbox, styles: Apply dark mode enabled color tokens

https://gerrit.wikimedia.org/r/1042262

Hey all, just a note that all these pages are disabled from night mode in production (see https://github.com/wikimedia/operations-mediawiki-config/blob/fb0b98da90919efe92e9026e2b8278cd27f65b19/wmf-config/skin-Minerva.php#L119). For example Preferences and ApiSandbox are not enabled in production yet. This is intentional so we are not overwhelmed chasing bug fixes. Don't feel all these fixes need to go in by Monday, in case that is a worry of yours, but thanks for working on these! If you could also tag the fix with the Phabricator ticket mentioned in wmgMinervaNightModeExcludeTitles that will also make sure we track them correctly.

ovasileva subscribed.Jun 12 2024, 4:42 PM

Change #1042214 merged by jenkins-bot:

[mediawiki/core@master] Preferences: Replace static color values with Codex tokens enabling dark mode

https://gerrit.wikimedia.org/r/1042214

Jdlrobson added a subtask: T367375: Search page doesn't work in dark mode.Jun 13 2024, 1:16 AM

Volker_E updated the task description. (Show Details)Jun 13 2024, 9:22 AM

Volker_E mentioned this in T366520: [Config] Dark mode is not available on Special:ApiSandbox.

Volker_E updated the task description. (Show Details)Jun 13 2024, 3:26 PM

Volker_E updated the task description. (Show Details)

Change #1043136 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] WikimediaUI theme: Fix primary button color in dark mode

https://gerrit.wikimedia.org/r/1043136