Page MenuHomePhabricator

Search page doesn't work in dark mode
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The Special:Search page does not appear in dark mode currently. The Special:Search page contains UIs from multiple extensions:

Screenshot 2024-06-13 at 10.06.14 AM.png (972×1 px, 316 KB)
Screenshot 2024-06-13 at 10.14.00 AM.png (807×1 px, 1 MB)

In dark-mode

Screenshot 2024-06-12 at 5.53.18 PM.png (392×1 px, 31 KB)
Screenshot 2024-06-12 at 5.53.38 PM.png (1×1 px, 85 KB)

User story

As a user I want all pages in dark mode

Requirements

Screenshot 2024-06-12 at 5.52.39 PM.png (852×604 px, 105 KB)

  • When I hover over search form the text should be readable
  • Advanced search should be readable.

Derived Requirement

Ensure that the search page works correctly in dark mode, with all elements displaying properly and text remaining readable.

BDD

Feature: Search Page Functionality in Dark Mode

Scenario: Ensure search page displays correctly in dark mode

Given the user has enabled dark mode
When the user navigates to the search page
Then all elements should display properly and text should be readable
Test Steps

Test Case 1: Ensure Search Page Displays Correctly in Dark Mode

Visit https://test.wikipedia.org/wiki/Special:Search in Dark Mode
Validate that it's displayed properly

Acceptance criteria

The remaining work should involve:

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - en.wikipedia.rg

When this is being QAed in production, before testing, please check that https://en.wikipedia.org/wiki/Special:Version says 1.43.0-wmf.11 for MediaWiki.

QA Results - Test.wiki

ACStatusDetails
1T367375#9923419

QA Results - PROD

ACStatusDetails
1T367375#9923419

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

These are broken due to not using design tokens. Quick fixes may be possible by adding skin-invert notheme class to relevant elements.

Change #1042247 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Enable dark mode

https://gerrit.wikimedia.org/r/1042247

Change #1042247 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] styles: Enable dark mode

https://gerrit.wikimedia.org/r/1042247

Jdlrobson set the point value for this task to 2.Jun 14 2024, 7:02 PM

Change #1047187 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/core@master] Use codex color value for interwiki header links in search

https://gerrit.wikimedia.org/r/1047187

Change #1047187 merged by jenkins-bot:

[mediawiki/core@master] Use codex color value for interwiki header links in search

https://gerrit.wikimedia.org/r/1047187

@Jdlrobson The only thing that came up was Advanced search as seen in the image below. Please let me know if this is already covered and if I can pass this or if this is an error, thanks!

Test Result - Test.wiki

Status: ❓NMI
Environment: Test.wiki
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

Test Case 1: Ensure Search Page Displays Correctly in Dark Mode

  1. Visit https://test.wikipedia.org/wiki/Special:Search in Dark Mode
  2. Validate that it's displayed properly
Special: SearchAdvance search"Search In:Add Namespace
2024-06-25_11-42-53.png (1×2 px, 338 KB)
2024-06-25_11-43-50.png (1×2 px, 214 KB)
In Advanced search: "Sort by relevance" failed color contrast
2024-06-25_11-46-10.png (725×2 px, 288 KB)
2024-06-25_11-47-32.png (1×2 px, 317 KB)
Jdlrobson added a subscriber: JScherer-WMF.

❓ In Advanced search: "Sort by relevance" failed color contrast

It looks like this is in a disabled state (it has an aria-disabled). I'll clarify with @JScherer-WMF if we need a follow up ticket for this.

❓ In Advanced search: "Sort by relevance" failed color contrast

It looks like this is in a disabled state (it has an aria-disabled). I'll clarify with @JScherer-WMF if we need a follow up ticket for this.

That's correct. Disabled elements do not need to pass 4.5:1 colour contrast checks. So this is ok, even if it's not ideal.

Change #1049972 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

Change #1049972 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:42:24Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:44:55Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:50:34Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] (duration: 08m 09s)

This comment was removed by Jdlrobson.
GMikesell-WMF added a subscriber: Edtadros.

Looks good. Resolving.

@Jdlrobson "Search" is white in PROD and fail contrast while Test.Wiki was black (as seen in my previous test)

Test Result - PROD

Status: ❌ FAIL
Environment: Test.wiki
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

Test Case 1: Ensure Search Page Displays Correctly in Dark Mode

  1. Visit https://en.wikipedia.org/wiki/Special:Search in Dark Mode
  2. Validate that it's displayed properly
Special: SearchAdvance search"Search In:Add Namespace
2024-07-16_11-17-03.png (1×1 px, 417 KB)
2024-07-16_11-17-55.png (1×1 px, 157 KB)
"Search" is white in PROD and fails contrast while Test.Wiki was black
2024-07-16_11-19-23.png (586×2 px, 228 KB)
2024-07-16_11-19-56.png (1×1 px, 201 KB)