Page MenuHomePhabricator

Search page doesn't work in dark mode
Open, HighPublic2 Estimated Story Points

Description

Background

The Special:Search page does not appear in dark mode currently. The Special:Search page contains UIs from multiple extensions:

Screenshot 2024-06-13 at 10.06.14 AM.png (972×1 px, 316 KB)
Screenshot 2024-06-13 at 10.14.00 AM.png (807×1 px, 1 MB)

In dark-mode

Screenshot 2024-06-12 at 5.53.18 PM.png (392×1 px, 31 KB)
Screenshot 2024-06-12 at 5.53.38 PM.png (1×1 px, 85 KB)

User story

As a user I want all pages in dark mode

Requirements

Screenshot 2024-06-12 at 5.52.39 PM.png (852×604 px, 105 KB)

  • When I hover over search form the text should be readable
  • Advanced search should be readable.

Acceptance criteria

The remaining work should involve:

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
In ProgressDTorsani-WMF
OpenNone
OpenBUG REPORTNone
OpenNone
OpenJdrewniak
OpenJdrewniak
Openovasileva
ResolvedJdlrobson
Openovasileva
Openovasileva
ResolvedJScherer-WMF
Resolvedovasileva
ResolvedSpikeSToyofuku-WMF
Openovasileva
Openovasileva
OpenNone
OpenBUG REPORTNone
Resolvedovasileva
ResolvedVolker_E
Openovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedFeatureNone
OpenNone
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Openovasileva
OpenBUG REPORTNone
OpenBUG REPORTNone
Resolvedovasileva
Resolvedovasileva
ResolvedBUG REPORTovasileva
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedNone
ResolvedJdrewniak
Resolvedovasileva
ResolvedBUG REPORTovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedJdlrobson
ResolvedJdlrobson
Resolvedovasileva
ResolvedJdrewniak
ResolvedJScherer-WMF
Resolvedovasileva
Resolvedovasileva
ResolvedBUG REPORTovasileva
ResolvedBUG REPORTovasileva
Stalledbwang
OpenNone
OpenGMikesell-WMF
OpenNone
OpenNone
OpenNone
DeclinedFeatureegardner
DuplicateNone
OpenEAkinloose
DuplicateBUG REPORTNone
DeclinedFeatureegardner
DuplicateCCiufo-WMF
Openovasileva
ResolvedNBaca-WMF
DeclinedVolker_E
OpenNone
OpenVolker_E
OpenNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

These are broken due to not using design tokens. Quick fixes may be possible by adding skin-invert notheme class to relevant elements.

Change #1042247 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Enable dark mode

https://gerrit.wikimedia.org/r/1042247

Change #1042247 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] styles: Enable dark mode

https://gerrit.wikimedia.org/r/1042247

Jdlrobson set the point value for this task to 2.Fri, Jun 14, 7:02 PM