Background
The Special:Search page does not appear in dark mode currently. The Special:Search page contains UIs from multiple extensions:
- ✅ Extension:SearchVue - buit with Codex, supports dark-mode
- ✅ extension:AdvancedSearch - contains custom colors
- ✅ Extension:MediaSearch (on commons) - built with Codex, supports dark-mode
- ❌ MediaWiki core - inherits dark-mode styles
- ✅ OOUI - now supports dark-mode
In dark-mode
User story
As a user I want all pages in dark mode
Requirements
- https://en.wikipedia.org/w/index.php?title=Special:Search should have no color contrast issues in dark mode.
- On https://en.wikipedia.org/w/index.php?search=S&title=Special:Search&profile=advanced&fulltext=1&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns710=1&ns711=1&ns828=1&ns829=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1 "Word definitions from Wiktionary" should be visible
- When I hover over search form the text should be readable
- Advanced search should be readable.
Derived Requirement
Ensure that the search page works correctly in dark mode, with all elements displaying properly and text remaining readable.
BDD
Feature: Search Page Functionality in Dark Mode
Scenario: Ensure search page displays correctly in dark mode
Given the user has enabled dark mode When the user navigates to the search page Then all elements should display properly and text should be readable
Test Steps
Test Case 1: Ensure Search Page Displays Correctly in Dark Mode
Visit https://test.wikipedia.org/wiki/Special:Search in Dark Mode
Validate that it's displayed properly
Acceptance criteria
The remaining work should involve:
- Use a design token for https://gerrit.wikimedia.org/g/mediawiki/core/+/8b050a2f0d859527c91b21df268e4d0634e14102/resources/src/mediawiki.special.search.interwikiwidget.styles.less#46 - use @color-emphasised
Communication criteria - does this need an announcement or discussion?
- Add communication criteria
Rollback plan
- What is the rollback plan in production for this task if something goes wrong?
This task was created by Version 1.0.0 of the Web team task template using phabulous
QA Results - en.wikipedia.rg
When this is being QAed in production, before testing, please check that https://en.wikipedia.org/wiki/Special:Version says 1.43.0-wmf.11 for MediaWiki.
QA Results - Test.wiki
AC | Status | Details |
---|---|---|
1 | ❓ | T367375#9923419 |
QA Results - PROD
AC | Status | Details |
---|---|---|
1 | ❌ | T367375#9923419 |