Page MenuHomePhabricator

Special:Notifications has color contrast issues in night mode
Open, HighPublic2 Estimated Story PointsBUG REPORT

Description

Details on why this is occurring and how team's can fix this are provided on T356434

Steps to replicate the issue (include links if applicable):

What happens?:
5 color contrast issues:

  • (including on hover)

What should have happened instead?:
No color contrast issues (See T356434 for solutions)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Acceptance criteria

  • Add notheme and skin-invert class to the page as a temporary workaround

Related Objects

StatusSubtypeAssignedTask
OpenJdrewniak
OpenJdrewniak
Openovasileva
Openovasileva
Openovasileva
OpenNone
OpenBUG REPORTbwang
OpenNone
DeclinedFeatureegardner
DuplicateNone
OpenEAkinloose
DuplicateBUG REPORTNone
DeclinedFeatureegardner
DuplicateCCiufo-WMF
Openovasileva
ResolvedNBaca-WMF
DeclinedVolker_E
OpenNone
OpenVolker_E
OpenEdtadros

Event Timeline

Jdlrobson lowered the priority of this task from High to Medium.Feb 29 2024, 6:51 PM
Jdlrobson lowered the priority of this task from Medium to Low.Mar 11 2024, 9:14 PM

This page has been configured to always show in day mode as part of T359183, so this is now less of a priority.

ovasileva raised the priority of this task from Low to Medium.Mar 12 2024, 9:30 AM
ovasileva subscribed.

Moving to next sprint to review priority again as we'll want to get these pages working in the future

Jdlrobson changed the task status from Open to Stalled.Mar 21 2024, 6:17 PM
Jdlrobson added a subscriber: Jdrewniak.

This and other related tickets are stalled on a decision for how to solve the problem for OOUI. @Jdrewniak is working on a spike to make that decision in this sprint.

Jdlrobson changed the task status from Stalled to Open.May 4 2024, 6:15 PM
Jdlrobson updated the task description. (Show Details)

As a short term solution we could add notheme class to the element until OOUI has support for CSS variables.

I'm looking at the Special:Notifications page with the in-progress OOUI update, and there are still a fair bit of color values that need to be changed in the Echo extension for this page to work in dark-mode. Luckily with the magic of codesearch, hardcoded hex values (#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})) are easy to identify:

ovasileva raised the priority of this task from Medium to High.Thu, Jun 20, 5:01 PM