⚓ T358405 Special:Notifications should work in night mode

AC	Status	Details
1	❓	T358405#9932910

AC	Status	Details
1	✅	T358405#9971722

	Subject	Repo	Branch	Lines +/-
	Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)	operations/mediawiki-config	master	+2 -21
	Fix dark mode issues on Special:Notifications	mediawiki/extensions/Echo	master	+2 -2

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved		ovasileva	T356434 [Night Mode] All pages and overlays that can be accessed within 2 clicks by a logged in user (AMC disabled) appear in night mode on mobile
Resolved		ovasileva	T360656 [GOAL] Interfaces using OOUI should work in night mode
Open		None	T366760 [EPIC] Dark mode for Growth team maintained features
Resolved	BUG REPORT	ovasileva	T358405 Special:Notifications should work in night mode
Resolved		Jdlrobson	T364777 [EPIC] Enable dark mode in OOUI
Declined	Feature	egardner	T363849 [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens
Duplicate		None	T364420 QA Editing-related night mode changes (desktop)
Resolved		ovasileva	T360691 QA Editing-related OOUI updates (mobile + desktop)
Duplicate	BUG REPORT	None	T365517 PopupWidget notification for hidden sidebars has white background
Declined	Feature	egardner	T363857 [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens
Duplicate		CCiufo-WMF	T365521 QA Editing-related REM changes
Resolved		ovasileva	T365764 [OOUI] Icons: Add support for use in dark mode
Resolved		NBaca-WMF	T366709 [Spike] Make a decision on what needs to happen for icons before the new OOUI release
Declined		Volker_E	T366101 [OOUI] Fix font size inconsistencies across skins with `rem` based sizing

Jdlrobson created this task.Feb 24 2024, 12:50 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 24 2024, 12:50 AM

Jdlrobson added projects: patch-welcome, good first task.Feb 24 2024, 1:19 AM

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 24 2024, 1:22 AM

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Feb 24 2024, 1:23 AM

Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Feb 28 2024, 12:54 AM

Etonkovidova added a subscriber: Sgs.

ovasileva triaged this task as High priority.Feb 29 2024, 2:06 PM

Jdlrobson lowered the priority of this task from High to Medium.Feb 29 2024, 6:51 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).Mar 11 2024, 7:08 PM

This page has been configured to always show in day mode as part of T359183, so this is now less of a priority.

Moving to next sprint to review priority again as we'll want to get these pages working in the future

This and other related tickets are stalled on a decision for how to solve the problem for OOUI. @Jdrewniak is working on a spike to make that decision in this sprint.

Jdlrobson added a parent task: T360656: [GOAL] Interfaces using OOUI should work in night mode.Mar 21 2024, 6:17 PM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 6).Mar 26 2024, 8:22 AM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 1).Apr 10 2024, 6:55 AM

Jdlrobson added a project: Wikimedia-Hackathon-2024.Apr 17 2024, 3:59 PM

Jdlrobson moved this task from Backlog to Hacking project: Dark mode on the Wikimedia-Hackathon-2024 board.Apr 17 2024, 4:04 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q4 Sprint 2).Apr 23 2024, 5:25 PM

KStoller-WMF moved this task from Needs Discussion to Triaged on the Growth-Team board.Apr 23 2024, 5:49 PM

As a short term solution we could add notheme class to the element until OOUI has support for CSS variables.

Jdlrobson removed a project: Web-Team-Backlog.May 15 2024, 12:20 AM

Jdlrobson moved this task from Night mode (mobile) to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.May 21 2024, 5:34 PM

SrikanthLunavath03 subscribed.May 29 2024, 8:38 AM

• Kalyan321 subscribed.May 29 2024, 12:08 PM

Jdlrobson added a subtask: T364777: [EPIC] Enable dark mode in OOUI.Jun 3 2024, 10:54 PM

KStoller-WMF added a parent task: T366760: [EPIC] Dark mode for Growth team maintained features.Jun 5 2024, 9:59 PM

I'm looking at the Special:Notifications page with the in-progress OOUI update, and there are still a fair bit of color values that need to be changed in the Echo extension for this page to work in dark-mode. Luckily with the magic of codesearch, hardcoded hex values (#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})) are easy to identify:

modules/echo.variables.less (5 matches)
modules/nojs/mw.echo.alert.less (1 matches)
modules/nojs/mw.echo.alert.monobook.less (1 matches)
modules/nojs/mw.echo.badge.less (1 matches)
modules/nojs/mw.echo.special.less (2 matches)
modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less (1 matches)
modules/styles/mw.echo.ui.MenuItemWidget.less (1 matches)
modules/styles/mw.echo.ui.NotificationItemWidget.less (2 matches)
modules/styles/mw.echo.ui.PageNotificationsOptionWidget.less (2 matches)
modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less (3 matches)

Jdlrobson mentioned this in T366322: Fix Echo color contrast issues in standard theme & night mode.Jun 12 2024, 4:00 PM

Jdlrobson mentioned this in T367151: [Config] Deploy dark mode to all users in tier 1 wikis on the Minerva skin .Jun 18 2024, 6:05 PM

ovasileva raised the priority of this task from Medium to High.Jun 20 2024, 5:01 PM

ovasileva added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 6).

Jdlrobson updated the task description. (Show Details)Jun 20 2024, 5:41 PM

ovasileva set the point value for this task to 2.Jun 20 2024, 5:42 PM

ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

bwang claimed this task.Jun 21 2024, 3:09 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 25 2024, 3:56 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 25 2024, 7:18 PM

Change #1049621 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Echo@master] Fix dark mode issues on Special:Notifications

https://gerrit.wikimedia.org/r/1049621

gerritbot added a project: Patch-For-Review.Jun 25 2024, 7:18 PM

bwang removed bwang as the assignee of this task.Jun 25 2024, 7:19 PM

bwang subscribed.

Jdlrobson assigned this task to GMikesell-WMF.Jun 25 2024, 11:14 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Change #1049621 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix dark mode issues on Special:Notifications

https://gerrit.wikimedia.org/r/1049621

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 26 2024, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 12:30 AM

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

gerritbot added a project: Patch-For-Review.Jun 26 2024, 3:45 PM

Jdlrobson closed subtask T364777: [EPIC] Enable dark mode in OOUI as Resolved.Jun 26 2024, 7:51 PM

@Jdlrobson Please review the other potential issues below. If they are being covered in another task, this can be moved to sign-off since the rest seems fine, thanks!

Test Result - Beta

Status: ❓NMI
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

✅No other issues except for disable and the potential ones below

2024-06-27_15-16-03.mp4.gif (918×1 px, 2 MB)

❓Please review the following below
"Unread" color black contrast issue

2024-06-27_15-07-34.png (875×2 px, 329 KB)

Example comment in the notifications, color contrast

2024-06-27_15-14-19.png (830×2 px, 326 KB)

Date and sub descriptions have color contrast

2024-06-27_15-14-53.png (740×2 px, 323 KB)

GMikesell-WMF updated the task description. (Show Details)Jun 27 2024, 10:32 PM

Sorry I forgot to update the task description @GMikesell-WMF (done now) this is fine. We'll address the color contrast issues later in T368691.

Jdlrobson removed a project: patch-welcome.Jun 28 2024, 2:29 AM

Looks good! Resolving.

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2024, 2:30 AM

GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBS
Emulated Device: NA

Test Artifact(s):

Test Steps

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Notifications?vectornightmode=1 making sure you have notifications
✅ AC1: Notifications should appear in a night theme.

Edtadros updated the task description. (Show Details)Jul 10 2024, 11:11 PM

Special:Notifications should work in night mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Acceptance criteria

QA Results - Beta

QA Results - Prod

Note

Details

Related Objects
Search...

Event Timeline

Test Result - Beta

Test Steps

Test Result - Prod

Test Steps

	F56340732: screenshot 131.png
	Jul 10 2024, 11:10 PM

	F56340731: screenshot 132.png
	Jul 10 2024, 11:10 PM

Special:Notifications should work in night modeClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Acceptance criteria

QA Results - Beta

QA Results - Prod

Note

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

Test Steps

Test Result - Prod

Test Steps

Special:Notifications should work in night mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Related Objects
Search...