Page MenuHomePhabricator

Special:Notifications should not invert content and use design tokens instead - should not have accessibility issues in light or dark mode.
Open, Needs TriagePublic3 Estimated Story Points

Assigned To
None
Authored By
Jdlrobson
Jun 27 2024, 11:43 PM
Referenced Files
F57738630: image.png
Nov 23 2024, 10:03 PM
F55933022: 2024-06-27_15-14-53.png
Jun 27 2024, 11:44 PM
F55933017: 2024-06-27_15-14-19.png
Jun 27 2024, 11:44 PM
F55933009: 2024-06-27_15-07-34.png
Jun 27 2024, 11:44 PM

Description

Background

In 358405 we took a short cut to make Special:Notifications look consistent with other pages. At the time we noted accessibility issues relating to color contrast in the light theme and decided to carry them over to the dark theme by applying the notheme and skin-invert classes to the content. Details on why this is occurring and how team's can fix this are provided on T356434

User story

As a reader I want an accessible experience when viewing Special:Notifications

Requirements

  • the notheme and skin-invert classes have been removed from the page
  • Hardcoded CSS property values are replaced with Codex design tokens. Update any hex codes e.g. color: #fff with the equivalent design token https://doc.wikimedia.org/codex/latest/design-tokens/overview.html
  • Light theme should have no accessibility issues
  • Dark theme should have no accessibility issues

BDD

  • For QA engineer to fill out

Test Steps

What happens?:
5 color contrast issues:

  • (including on hover)

What should have happened instead?:
No color contrast issues (See T356434 for solutions)

Design

❓Please review the following below
"Unread" color black contrast issue

2024-06-27_15-07-34.png (2,654×875 px, 329 KB)

Example comment in the notifications, color contrast
2024-06-27_15-14-19.png (2,647×830 px, 326 KB)

Date and sub descriptions have color contrast
2024-06-27_15-14-53.png (2,654×740 px, 323 KB)

Acceptance criteria

  • has color contrast issues in night mode

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson renamed this task from Special:Notifications should not invert content and use design tokens to Special:Notifications should not invert content and use design tokens instead - should not have accessibility issues in light or dark mode..Jun 27 2024, 11:43 PM
Jdlrobson added a project: Accessibility.
Jdlrobson updated the task description. (Show Details)

The "Unread" button color seems to have been fixed.

Some labels like "Pages with unread notifications" or the heading that shows the date use the color-placeholder token and still don't have enough contrast (according to the chrome extension).
Using color-subtle improves the contrast but also makes it stand out a bit more, so not sure whether that's a good solution:

image.png (292×131 px, 8 KB)

Sgs set the point value for this task to 3.Jan 7 2025, 4:40 PM