⚓ T366373 [Config change] Enable night theme on pages which use data tables

AC	Status	Details
1	❌	T366373#9983202

Subject	Repo	Branch	Lines +/-
Enable dark mode on more pages	operations/mediawiki-config	master	+7 -18
Enable dark mode on more pages	operations/mediawiki-config	master	+9 -20
DataTables: Fix theme in os mode	mediawiki/core	master	+1 -1
Pager: Fix data tables in night mode	mediawiki/core	master	+11 -1

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T366373 [Config change] Enable night theme on pages which use data tables
		Resolved		Jdlrobson	T365383 [Spike] QA outcome of OOUI work

Jdlrobson created this task.May 31 2024, 4:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 4:09 PM

Jdlrobson renamed this task from Enable night theme on Special:TrackingCategories to Enable night theme on pages which use data tables.May 31 2024, 4:14 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .

Jdlrobson updated the task description. (Show Details)May 31 2024, 4:29 PM

Jdlrobson updated the task description. (Show Details)May 31 2024, 4:40 PM

Jdlrobson updated the task description. (Show Details)May 31 2024, 4:46 PM

Jdlrobson triaged this task as Medium priority.May 31 2024, 4:49 PM

Jdlrobson added a project: Web-Team-Backlog-Archived.May 31 2024, 4:56 PM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog-Archived board.May 31 2024, 5:03 PM

Change #1037837 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Fix data tables in night mode

https://gerrit.wikimedia.org/r/1037837

gerritbot added a project: Patch-For-Review.May 31 2024, 6:12 PM

Change #1037837 merged by jenkins-bot:

[mediawiki/core@master] Pager: Fix data tables in night mode

https://gerrit.wikimedia.org/r/1037837

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Jun 1 2024, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2024, 12:30 AM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

Change #1038374 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] DataTables: Fix theme in os mode

https://gerrit.wikimedia.org/r/1038374

gerritbot added a project: Patch-For-Review.Jun 3 2024, 3:17 PM

Change #1038374 abandoned by Jdlrobson:

[mediawiki/core@master] DataTables: Fix theme in os mode

Reason:

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1037837/3/resources/src/mediawiki.pager.styles/DataTable.less

https://gerrit.wikimedia.org/r/1038374

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2024, 3:31 PM

This looks good to go, when OOUI is prepped for dark mode.

TablePager-button-prev uses OOUI
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:BlockList

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:AbuseLog

Screenshot 2024-06-03 at 9.18.59 AM.png (164×564 px, 13 KB)

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog-Archived.Jun 3 2024, 4:21 PM

Jdlrobson updated the task description. (Show Details)Jun 3 2024, 6:50 PM

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.Jun 6 2024, 8:33 PM

Edtadros mentioned this in T366331: Verify 1.43.0-wmf.8 deployment.Jun 10 2024, 9:20 PM

Change #1041250 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on data table pages

https://gerrit.wikimedia.org/r/1041250

gerritbot added a project: Patch-For-Review.Jun 10 2024, 11:12 PM

Patch can be backported 20th at the latest (as the OOUI release is required)

Jdlrobson updated the task description. (Show Details)Jun 10 2024, 11:14 PM

I reviewed all these pages, and it looks like none of them have color contrast issues. The earliest this can happen is June 20th.

Jdlrobson renamed this task from Enable night theme on pages which use data tables to [Config change] Enable night theme on pages which use data tables.Jun 12 2024, 9:18 PM

Jdlrobson changed the task status from Stalled to Open.

Jdlrobson added a project: Wikimedia-Site-requests.

Jdlrobson updated the task description. (Show Details)

Adding 1 as this is a configuration change.

Change #1042431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1042431

ovasileva added a parent task: T367151: [Config] Deploy dark mode to all users in tier 1 wikis on the Minerva skin .Jun 17 2024, 12:42 PM

Jdlrobson closed subtask T365383: [Spike] QA outcome of OOUI work as Resolved.Jun 17 2024, 10:19 PM

ovasileva moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.Jun 20 2024, 4:56 PM

I'll enable this on Monday.

Jdlrobson claimed this task.Jun 21 2024, 12:44 AM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.Jun 25 2024, 3:28 PM

Change #1042431 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable dark mode on more pages

Reason:

Folded into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1041250

https://gerrit.wikimedia.org/r/1042431

Jdlrobson reassigned this task from Jdlrobson to KSarabia-WMF.Jun 25 2024, 5:29 PM

Change #1041250 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1041250

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:16:21Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:19:01Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:31:25Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] (duration: 15m 04s)

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2024, 8:31 PM

Jdlrobson reassigned this task from KSarabia-WMF to GMikesell-WMF.Jun 25 2024, 8:57 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Jdlrobson added a subscriber: KSarabia-WMF.

Jdlrobson updated the task description. (Show Details)Jun 25 2024, 11:15 PM

ovasileva removed a parent task: T367151: [Config] Deploy dark mode to all users in tier 1 wikis on the Minerva skin .Jul 1 2024, 2:06 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6).Jul 1 2024, 5:35 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.

Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 2); removed Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1).Jul 15 2024, 6:00 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 2) board.

GMikesell-WMF updated the task description. (Show Details)Jul 15 2024, 7:29 PM

@Jdlrobson Please review issues below, thanks!

Test Result - PROD

Status: ❌ FAIL
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Night Theme on Data Table Pages

Enable the night theme on the site.
Navigate to a page containing data tables. Night mode is enabled on https://en.wikipedia.org/wiki/Special:TrackingCategories Night mode is enabled on https://en.wikipedia.org/w/index.php?title=Special:AutoblockList Night mode is enabled on https://en.wikipedia.org/wiki/Special:BlockList?safemode=1 Night mode is enabled on https://en.wikipedia.org/w/index.php?title=Special:AbuseLog Night mode is enabled on https://en.wikipedia.org/w/index.php?title=Special:AbuseFilter Night mode is enabled on https://en.wikipedia.org/wiki/Special:BlockedExternalDomains https://en.wikipedia.org/w/index.php?title=Special:Tags https://en.wikipedia.org/w/index.php?title=Special:TopicSubscriptions https://en.wikipedia.org/w/index.php?title=Special:ListFiles Night mode is enabled on https://en.m.wikipedia.org/wiki/Special:SecurePoll Night mode is enabled on https://en.wikipedia.org/wiki/Special:PageAssessments?project=&namespace=0&page_title=San+Francisco

❌ AC1: Confirm the page displays using the night theme.

✅
❌	"Search" contrast failed & table is off & overlaps
❌	"Search" contrast failed
✅
❌	Some are grey for some reason like "by", "Public",etc
✅
❌	Table is off and overlaps
✅
❌	"Show file list" contrast failed & table is off & overlaps
✅
❌	"Search" contrast failed

GMikesell-WMF updated the task description. (Show Details)Jul 15 2024, 7:50 PM

Thanks!

❌ "Search" contrast failed & table is off & overlaps {F This is now fixed on test.wikipedia.org (Was reported in another bug). Overlap reported in T370188

❌ Some are grey for some reason like "by", "Public",etc
Tracked in T370191

❌ Table is off and overlaps
Overlap reported in T370188

❌ "Show file list" contrast failed & table is off & overlaps
This is now fixed on test.wikipedia.org (Was reported in another bug). Overlap reported in T370188

❌ "Search" contrast failed
This is now fixed on test.wikipedia.org (Was reported in another bug)

Jdlrobson reassigned this task from GMikesell-WMF to ovasileva.Jul 26 2024, 10:12 PM

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 2) board.

Jdlrobson added a subscriber: GMikesell-WMF.

[Config change] Enable night theme on pages which use data tables
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

User story

Acceptance criteria

Derived Requirement

BDD

Test Steps

QA

Communication criteria - does this need an announcement or discussion?

Rollback plan

QA Results - PROD

Details

Related Objects
Search...

Event Timeline

Test Result - PROD

Test Steps

❌	"Search" contrast failed & table is off & overlaps {F	This is now fixed on test.wikipedia.org (Was reported in another bug). Overlap reported in T370188
❌	Some are grey for some reason like "by", "Public",etc	Tracked in T370191
❌	Table is off and overlaps	Overlap reported in T370188
❌	"Show file list" contrast failed & table is off & overlaps	This is now fixed on test.wikipedia.org (Was reported in another bug). Overlap reported in T370188
❌	"Search" contrast failed	This is now fixed on test.wikipedia.org (Was reported in another bug)

[Config change] Enable night theme on pages which use data tablesClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Background

User story

Acceptance criteria

Derived Requirement

BDD

Test Steps

QA

Communication criteria - does this need an announcement or discussion?

Rollback plan

QA Results - PROD

Details

Related ObjectsSearch...

Event Timeline

Test Result - PROD

Test Steps

[Config change] Enable night theme on pages which use data tables
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...