Page MenuHomePhabricator
Create Task
Maniphest T366373

[Config change] Enable night theme on pages which use data tables
Open, MediumPublic1 Estimated Story Points
Actions

Assigned To
GMikesell-WMF
Authored By
Jdlrobson
Fri, May 31, 4:09 PM
Tags
Referenced Files
F54907705: Screenshot 2024-06-03 at 9.18.59 AM.png
Mon, Jun 3, 4:20 PM
F54907698: Screenshot 2024-06-03 at 9.18.38 AM.png
Mon, Jun 3, 4:20 PM
F54907691: Screenshot 2024-06-03 at 9.18.21 AM.png
Mon, Jun 3, 4:20 PM
Subscribers
Aklapper
Jdlrobson
KSarabia-WMF

Description

NOTE: 20th June is the earliest this can currently be deployed (when OOUI update will hopefully be enabled on all projects)

Background

Night theme doesn't work on Special:TrackingCategories

User story

As a user I want all my pages in dark mode.

Acceptance criteria

QA

Check that none of the pages have:

  1. AA color contrast issues for text that is not disabled (these are okay)
  2. icons that are the same color as the background.

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

SubjectRepoBranchLines +/-
Enable dark mode on more pagesoperations/mediawiki-configmaster+7 -18
Enable dark mode on more pagesoperations/mediawiki-configmaster+9 -20
DataTables: Fix theme in os modemediawiki/coremaster+1 -1
Pager: Fix data tables in night modemediawiki/coremaster+11 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Fri, May 31, 4:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 31, 4:09 PM
Jdlrobson renamed this task from Enable night theme on Special:TrackingCategories to Enable night theme on pages which use data tables.Fri, May 31, 4:14 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .
Jdlrobson updated the task description. (Show Details)Fri, May 31, 4:29 PM
Jdlrobson updated the task description. (Show Details)Fri, May 31, 4:40 PM
Jdlrobson updated the task description. (Show Details)Fri, May 31, 4:46 PM
Jdlrobson triaged this task as Medium priority.Fri, May 31, 4:49 PM
Jdlrobson added a project: Web-Team-Backlog.Fri, May 31, 4:56 PM
Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Fri, May 31, 5:03 PM
gerritbot added a comment.Fri, May 31, 6:12 PM

Change #1037837 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Fix data tables in night mode

https://gerrit.wikimedia.org/r/1037837

gerritbot added a project: Patch-For-Review.Fri, May 31, 6:12 PM
gerritbot added a comment.Fri, May 31, 11:36 PM

Change #1037837 merged by jenkins-bot:

[mediawiki/core@master] Pager: Fix data tables in night mode

https://gerrit.wikimedia.org/r/1037837

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Sat, Jun 1, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sat, Jun 1, 12:30 AM
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Mon, Jun 3, 1:44 AM
gerritbot added a comment.Mon, Jun 3, 3:17 PM

Change #1038374 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] DataTables: Fix theme in os mode

https://gerrit.wikimedia.org/r/1038374

gerritbot added a project: Patch-For-Review.Mon, Jun 3, 3:17 PM
gerritbot added a comment.Mon, Jun 3, 3:22 PM

Change #1038374 abandoned by Jdlrobson:

[mediawiki/core@master] DataTables: Fix theme in os mode

Reason:

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1037837/3/resources/src/mediawiki.pager.styles/DataTable.less

https://gerrit.wikimedia.org/r/1038374

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 3, 3:31 PM
Jdlrobson added a subtask: T365383: [Spike] QA outcome of OOUI work .Mon, Jun 3, 4:20 PM

This looks good to go, when OOUI is prepped for dark mode.

TablePager-button-prev uses OOUI
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:BlockList

Screenshot 2024-06-03 at 9.18.21 AM.png (180×1 px, 33 KB)

Screenshot 2024-06-03 at 9.18.38 AM.png (174×1 px, 21 KB)

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:AbuseLog

Screenshot 2024-06-03 at 9.18.59 AM.png (164×564 px, 13 KB)

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog.Mon, Jun 3, 4:21 PM
Jdlrobson updated the task description. (Show Details)Mon, Jun 3, 6:50 PM
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 6, 8:33 PM
Edtadros mentioned this in T366331: Verify 1.43.0-wmf.8 deployment.Mon, Jun 10, 9:20 PM
gerritbot added a comment.Mon, Jun 10, 11:12 PM

Change #1041250 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on data table pages

https://gerrit.wikimedia.org/r/1041250

gerritbot added a project: Patch-For-Review.Mon, Jun 10, 11:12 PM
Jdlrobson changed the task status from Open to Stalled.Mon, Jun 10, 11:12 PM
Jdlrobson updated the task description. (Show Details)

Patch can be backported 20th at the latest (as the OOUI release is required)

Jdlrobson updated the task description. (Show Details)Mon, Jun 10, 11:14 PM
Jdlrobson updated the task description. (Show Details)Wed, Jun 12, 9:16 PM

I reviewed all these pages, and it looks like none of them have color contrast issues. The earliest this can happen is June 20th.

Jdlrobson renamed this task from Enable night theme on pages which use data tables to [Config change] Enable night theme on pages which use data tables.Wed, Jun 12, 9:18 PM
Jdlrobson changed the task status from Stalled to Open.
Jdlrobson added a project: Wikimedia-Site-requests.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 1.Thu, Jun 13, 12:13 AM
Jdlrobson moved this task from Ready for estimation to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Adding 1 as this is a configuration change.

gerritbot added a comment.Thu, Jun 13, 12:25 AM

Change #1042431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1042431

ovasileva added a parent task: T367151: [Config] Deploy dark mode to all users on the Minerva skin .Mon, Jun 17, 12:42 PM
Jdlrobson closed subtask T365383: [Spike] QA outcome of OOUI work as Resolved.Mon, Jun 17, 10:19 PM
ovasileva moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 4:56 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 6:12 PM

I'll enable this on Monday.

Jdlrobson claimed this task.Fri, Jun 21, 12:44 AM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Tue, Jun 25, 3:28 PM
gerritbot added a comment.Tue, Jun 25, 3:33 PM

Change #1042431 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable dark mode on more pages

Reason:

Folded into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1041250

https://gerrit.wikimedia.org/r/1042431

Jdlrobson reassigned this task from Jdlrobson to KSarabia-WMF.Tue, Jun 25, 5:29 PM
gerritbot added a comment.Tue, Jun 25, 8:15 PM

Change #1041250 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1041250

Stashbot mentioned this in T366378: [Config change] Enable night theme on preferences pages.Tue, Jun 25, 8:16 PM
Stashbot mentioned this in T367374: [Config] Enable dark mode on protect and deletion pages.
Stashbot mentioned this in T366520: [Config] Dark mode is not available on Special:ApiSandbox.

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:16:21Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]]

Stashbot added a comment.Tue, Jun 25, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:19:01Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Tue, Jun 25, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:31:25Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] (duration: 15m 04s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 8:31 PM
Jdlrobson reassigned this task from KSarabia-WMF to GMikesell-WMF.Tue, Jun 25, 8:57 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
Jdlrobson added a subscriber: KSarabia-WMF.
Jdlrobson updated the task description. (Show Details)Tue, Jun 25, 11:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL