Page MenuHomePhabricator

DiscussionTools source mode preview is not night mode friendly
Open, HighPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The text in the input is not visible (note this will be addressed by T366197)
  • The preview is not visible

What should have happened instead?:
Both should be visible.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Jdlrobson created this task.

Options to fix this:

  1. Add notheme to ext-discussiontools-ui-replyWidget-bodyWrapper and ext-discussiontools-ui-replyWidget-preview
  2. Add skin-invert to ext-discussiontools-ui-replyWidget-preview and update tokens in to ext-discussiontools-ui-replyWidget-bodyWrapper (it doesn't look like invert works on the input)
  3. Update to ext-discussiontools-ui-replyWidget-bodyWrapper and ext-discussiontools-ui-replyWidget-preview to use design tokens

As far as I see,

  • The visual mode isn’t better: a visual draft is also white-on-white (except for links and when selected).
  • The currently not selected tab, as well as all toolbar buttons are black-on-black (unless hovered).
Source modeVisual mode
Screenshot 2024-06-13 at 17-53-04 Talk T352930 - Wikipedia the free encyclopedia.png (551×1 px, 75 KB)
Screenshot 2024-06-13 at 17-53-28 Talk T352930 - Wikipedia the free encyclopedia.png (490×1 px, 66 KB)

As far as I see,

  • The visual mode isn’t better: a visual draft is also white-on-white (except for links and when selected).
  • The currently not selected tab, as well as all toolbar buttons are black-on-black (unless hovered).
Source modeVisual mode
Screenshot 2024-06-13 at 17-53-04 Talk T352930 - Wikipedia the free encyclopedia.png (551×1 px, 75 KB)
Screenshot 2024-06-13 at 17-53-28 Talk T352930 - Wikipedia the free encyclopedia.png (490×1 px, 66 KB)

This should be covered by T366197: VisualEditor should use Codex design tokens for custom colors

As far as I know, the source mode input box is also a VisualEditor (2017WTE) input – unless the source mode toolbar is turned off, in which case it’s an OOUI textbox, and is at least readable:

Screenshot 2024-06-14 at 09-35-41 Talk Pywikibot March Workshop_Archive 1 - Test Wikipedia.png (400×948 px, 43 KB)

So then only the preview is a task specific to DiscussionTools?

Jdlrobson renamed this task from Discussion tools source tab is not night mode friendly to Discussion tools preview source tab is not night mode friendly.Fri, Jun 14, 2:51 PM
Jdlrobson updated the task description. (Show Details)

Yeh looks like it. If you add the following rule it fixes the input areas:

.ve-ui-targetWidget:not(.oo-ui-pendingElement-pending) {background: var(--background-color-base); }

Devs feel this is better estimated when VisualEditor is resolved.

Tacsipacsi renamed this task from Discussion tools preview source tab is not night mode friendly to DiscussionTools source mode preview is not night mode friendly.Sun, Jun 16, 1:17 PM