As far as I see,

• The visual mode isn’t better: a visual draft is also white-on-white (except for links and when selected).
• The currently not selected tab, as well as all toolbar buttons are black-on-black (unless hovered).

Source mode	Visual mode

In T367432#9889565, @Tacsipacsi wrote:

As far as I see,

• The visual mode isn’t better: a visual draft is also white-on-white (except for links and when selected).
• The currently not selected tab, as well as all toolbar buttons are black-on-black (unless hovered).

Source mode	Visual mode

This should be covered by T366197: VisualEditor should use Codex design tokens for custom colors

As far as I know, the source mode input box is also a VisualEditor (2017WTE) input – unless the source mode toolbar is turned off, in which case it’s an OOUI textbox, and is at least readable:

So then only the preview is a task specific to DiscussionTools?

Yeh looks like it. If you add the following rule it fixes the input areas:

.ve-ui-targetWidget:not(.oo-ui-pendingElement-pending) {background: var(--background-color-base); }

Devs feel this is better estimated when VisualEditor is resolved.

I don’t know about any other task related to in-page parts of DiscussionTools, so I put some other color contrast issues I’ve just noticed here, letting y’all decide if they need a separate task(s):

Timestamp (permalink)	Reply button

Thanks!

Change #1048146 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DiscussionTools@master] Fixes the preview area on discussion tools

https://gerrit.wikimedia.org/r/1048146

Change #1049999 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/DiscussionTools@master] Add notheme to discussion source mode preview

https://gerrit.wikimedia.org/r/1049999

Change #1049999 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix white on white text in source preview

https://gerrit.wikimedia.org/r/1049999

Change #1048146 abandoned by Jdlrobson:

[mediawiki/extensions/DiscussionTools@master] Disable preview area background in dark mode

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1049999

https://gerrit.wikimedia.org/r/1048146

The change is now on the beta cluster and talk pages are suddenly looking a lot better!
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:T352930&action=edit&redlink=1
Thanks for the assist @Esanders

@Jdlrobson Text input, preview, and source are now visible. I will move this to sign-off. I'm not sure if you wanted to count the date in the preview box as a contrast issue or not but I'm just letting you know about it, thanks!

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

✅AC1: The text in the input and preview is visible

@Jdlrobson Please review PROD when compared to Beta. It's different and the color contrast is off, thanks!

Test Result - PROD

Status: ❌ FAIL
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

❌AC1: The text in the input and preview is visible

PROD	Beta

Hi @GMikesell-WMF these look like they are testing 2 different workflows - you need to click "reply" on English Wikipedia. Looks like that is working okay?

@Jdlrobson Got it. It was weird that Beta went straight to a reply compared to PROD. It now passes, thanks!

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

✅ AC1: The text in the input and preview is visible

PROD	Beta

In T367432#9971257, @GMikesell-WMF wrote:

It was weird that Beta went straight to a reply compared to PROD.

It looks like you’ve already had a draft on beta (saved in the browser local storage), so when you opened the talk page, DiscussionTools immediately restored it (notice the notification that’s partly visible in the top right corner).