Page MenuHomePhabricator

Don't show hide options for anon edits on RC with disabled anon editing
Closed, DuplicatePublic

Description

With disabled anon editing $wgGroupPermissions['*']['edit'] = false;

the Special:RecentChanges options "Hide anonymous users" and "Hide logged-in users" make no sense

Details

Reference
bz34789

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:10 AM
bzimport set Reference to bz34789.
bzimport added a subscriber: Unknown Object (MLST).

What if you change your permissions?

What do you mean? Allow editing for all so the links on RC make sense? :D

(In reply to comment #2)

What do you mean? Allow editing for all so the links on RC make sense? :D

No, what if you have anonymous editing then disable it? Then you'd be unable to sort the RC entries.

That's what the request is all about. Return the hide link for anon edits only if editing is allowed for anons.

(In reply to comment #4)

That's what the request is all about. Return the hide link for anon edits only
if editing is allowed for anons.

You're missing the point. If your recentchanges table has both anon and logged in edits (because you allowed anon edits), and then you change it to logged-in-users only being able to edit....your recentchanges table will still have anonymous edits in it and removing those sort options wouldn't make sense.

Ah ok. Anyway, the point remains: on a wiki with with $wgGroupPermissions['*']['edit'] = false; the links make no sense. I had to disable them in the core code since there is no setting for it. Maybe a hook?