Page MenuHomePhabricator
Create Task
Maniphest T368348

Change form submission and new-wish button labels
Open, Needs TriagePublic
Actions

Description

  • The ‘Submit wish’ button label should be ‘Make a wish’ instead.
  • The form save button should use the existing publishpage and publishchanges messages, for saving new and existing wishes respectively.

Details

TitleReferenceAuthorSource BranchDest Branch
Switch back to custom save button labelsrepos/commtech/wishlist-intake!114samwilsonsave-button-labelsmain
Use existing publishpage/publishchanges messages for form's save buttonrepos/commtech/wishlist-intake!98samwilsonpublish-buttonmain
Customize query in GitLab

Event Timeline

Samwilson created this task.Tue, Jun 25, 4:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jun 25, 4:14 AM
Samwilson renamed this task from Change ‘Submit wish’ button to ‘Make a wish’ to Change form submission and new-wish button labels.Tue, Jun 25, 5:48 AM
Samwilson updated the task description. (Show Details)
Samwilson added a subscriber: JSengupta-WMF.Tue, Jun 25, 5:50 AM

@JSengupta-WMF just checking, did you want the form saving button to be "Publish page" and "Publish changes"? Or was it "Publish wish" and "Publish changes"?

CodeReviewBot added a project: Patch-For-Review.Tue, Jun 25, 5:56 AM

samwilson opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/98

Use existing publishpage/publishchanges messages for form's save button

CodeReviewBot added a comment.Tue, Jun 25, 8:02 AM

musikanimal merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/98

Use existing publishpage/publishchanges messages for form's save button

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 25, 8:30 AM
dom_walden added a project: Community Wishlist Survey (Intake form).Tue, Jun 25, 8:31 AM
JSengupta-WMF added a comment.Tue, Jun 25, 9:23 AM

We can keep it "Publish" and "Save changes" respectively for submission and edit.

JWheeler-WMF assigned this task to Samwilson.Wed, Jun 26, 3:19 PM
CodeReviewBot added a project: Patch-For-Review.Thu, Jun 27, 6:30 AM

samwilson opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/114

Switch back to custom save button labels

Samwilson moved this task from In development to Feedback and review on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.Thu, Jun 27, 6:31 AM
CodeReviewBot added a comment.Thu, Jun 27, 8:19 AM

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/114

Switch back to custom save button labels

Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 27, 8:30 AM
Samwilson moved this task from Feedback and review to QA on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.Thu, Jun 27, 8:35 AM
dom_walden moved this task from QA to Done on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.Fri, Jun 28, 1:51 PM
dom_walden subscribed.

As part of doing other testing, I have seen and translated the new buttons.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits