Page MenuHomePhabricator

mw-collapsible-text should use standard link colors
Open, MediumPublic1 Estimated Story Points

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The [show]/[hide] links within mw-collapsible elements have color #0645ad in Vector 2022. This is not accessible against the black background of dark mode.

en.wikipedia.org_wiki_Edna_Hibel.png (72×1 px, 14 KB)

They also have a non-standard orange active state

en.wikipedia.org_wiki_Edna_Hibel (1).png (72×1 px, 14 KB)

What should have happened instead?:

These should probably be changed to use the same link colors as the rest of the interface

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Hey @Pcoombe could you share your screenshots? They are set to private.

I don't think we alter the color of collapsible elements - is it possible these are being set on wiki?

Apologies, I fixed the files

It's defined in resources/src/jquery/jquery.makeCollapsible.less to use the non-Codex variable @color-link, which itself is defined in resources/src/mediawiki.less/mediawiki.skin.defaults.less. Not sure what the best approach to fix this would be.

Change #1050044 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] makeCollapsible: Use Codex link mixin cdx-mixin-link-base

https://gerrit.wikimedia.org/r/1050044

Jdlrobson lowered the priority of this task from High to Medium.

Change #1050044 merged by jenkins-bot:

[mediawiki/core@master] makeCollapsible: Use Codex link mixin cdx-mixin-link-base

https://gerrit.wikimedia.org/r/1050044