Make Night-mode-unaware-background-color lint visible and low priority
Open, HighPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Thu, Jun 27, 8:36 PM

Description

Background

Following discussion on https://en.wikipedia.org/wiki/Wikipedia_talk:Linter#Moving_%22Night-mode-unaware-background-color%22_out_of_tracking_into_high we'd like to move this lint into a low priority and visible lint. Dark mode is scheduled for deploy in July.

User story

AS an editor reacting to dark mode, I need a list of pages that need fixing.

Requirements

Night-mode-unaware-background-color appears on Special:LintErrors

BDD

For QA engineer to fill out

Test Steps

For QA engineer to fill out

Design

Add mockups and design requirements

Acceptance criteria

Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

Add communication criteria

We will update https://en.m.wikipedia.org/wiki/Wikipedia:Linter

Rollback plan

What is the rollback plan in production for this task if something goes wrong?

Reverting the patch should hide the lint category again.

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

	Subject	Repo	Branch	Lines +/-
	Make night-mode-unaware-background-color lint rule visible	mediawiki/extensions/Linter	master	+1 -1

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Thu, Jun 27, 8:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 27, 8:36 PM

In Linter's extension.json:

				"night-mode-unaware-background-color": {
					"dbid": 22,
					"enabled": true,
					"priority": "none",
					"no-params": true
				},

wants to become

				"night-mode-unaware-background-color": {
					"dbid": 22,
					"enabled": true,
					"priority": "low",
					"no-params": true
				},

This would then need to ride the train, or be backported as appropriate.

Marking it "priority": "low" will make it visible:

	/**
	 * Categories that are configured to be displayed to users
	 *
	 * @return string[]
	 */
	public function getVisibleCategories() {
		return array_merge(
			$this->categories[self::HIGH],
			$this->categories[self::MEDIUM],
			$this->categories[self::LOW]
		);
	}

	/**
	 * Categories that are configured to not be displayed to users
	 *
	 * @return string[]
	 */
	public function getInvisibleCategories() {
		return $this->categories[self::NONE];
	}

Reedy renamed this task from Make Night-mode-unaware-background-color lint visible and low priority. to Make Night-mode-unaware-background-color lint visible and low priority.Thu, Jun 27, 8:54 PM

Reedy added a project: MediaWiki-extensions-Linter.

Change #1050466 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Linter@master] Make night-mode-unaware-background-color lint rule visible

https://gerrit.wikimedia.org/r/1050466

gerritbot added a project: Patch-For-Review.Thu, Jun 27, 9:13 PM