Gitlab patch here

Gravy Secure Fields Card Payment Sequence Diagram (One-time)

Recurring to follow once code reviewed and merged.

Note: a lot is going on here, so I deliberately left a bunch of things out, including recurring, monthly convert and some of the generic processing steps.

Do we want to add the step for vaulting card for recurring donations, and if we want to use Alt for the step: check if donor record in Gravy?

In T369105#9975592, @AnnWF wrote:

Do we want to add the step for vaulting card for recurring donations, and if we want to use Alt for the step: check if donor record in Gravy?

Hi @Wfan. My plan was to add an alternative diagram for recurring, showing a slightly different flow as I think it changes in a few places.

Thanks for the heads-up about the Alt construct! I had no idea that existed! I have updated the image to now include an Alt block showing how we will create the donor record on the gravy side if it doesn't already exist.

This is ready for review again.

In T369105#9987352, @jgleeson wrote:

In T369105#9975592, @AnnWF wrote:

Do we want to add the step for vaulting card for recurring donations, and if we want to use Alt for the step: check if donor record in Gravy?

Hi @Wfan. My plan was to add an alternative diagram for recurring, showing a slightly different flow as I think it changes in a few places.

Thanks for the heads-up about the Alt construct! I had no idea that existed! I have updated the image to now include an Alt block showing how we will create the donor record on the gravy side if it doesn't already exist.

Thanks for the explanation, if this is only for one time, could we add something like (one-time success route) to the graph title since this is not covering the failed and recurring route? In addition, please check the link again, seems like Alt block should wrap both condition, which we also need to include the condition if getDonorRecord success.

Thanks again @Wfan for the additional feedback. I've updated the image to show the correct format for the Alt block and updated the title as requested. I agree that it makes sense to differentiate them, especially when we add new ones. Here's the latest:

The associated gitlab commit is here.

Looks good, thanks Jack :)