Page MenuHomePhabricator
Create Task
Maniphest T371537

MVP: Privately serve wikitech via mwdebug1001
Closed, ResolvedPublic
Actions

Description

What?
All configuration for labswiki already exists in our current mediawiki images, since it is part of mediawiki-config. Thus theoretically, it will be just as easy by adding this VirtualHost on apache.

How?

Testing

  • Read an article
  • Reset user password
  • Login using db authentication
  • Edit an article as a logged in user
  • Perform an action that would trigger a job
  • Upload a media file

Verify
We should verify the following:

  • Jobs are enqueued properly in our generic jobqueue
  • kask is used for user sessions

Details

SubjectRepoBranchLines +/-
wikitech: de-wikitech mediawiki-configoperations/mediawiki-configmaster+27 -47
mediawiki: add wikitech to virtual hostsoperations/puppetproduction+12 -0
background.js: Allow wikitech.wikimedia.orgperformance/WikimediaDebugmaster+0 -4
trafficserver: Allow XWD to be used for wikitechoperations/puppetproduction+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

jijiki created this task.Jul 31 2024, 6:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2024, 6:23 PM
bd808 subscribed.Jul 31 2024, 8:59 PM

The config thing that most needs to be changed to use the multiversion images is /etc/mediawiki/WikitechPrivateSettings.php where a number of secrets are provisioned. These may all end up being related to functionality that will be removed along with the LDAP auth.

jijiki added a comment.Aug 1 2024, 10:21 AM
In T371537#10033727, @bd808 wrote:

The config thing that most needs to be changed to use the multiversion images is /etc/mediawiki/WikitechPrivateSettings.php where a number of secrets are provisioned. These may all end up being related to functionality that will be removed along with the LDAP auth.

Indeed, removing this functionality is the easiest way to go as stated in the task

akosiaris renamed this task from MVP: Privately server wiktech via mw-on-k8s to MVP: Privately serve wikitech via mw-on-k8s.Aug 1 2024, 10:59 AM
akosiaris moved this task from Incoming 🐫 to this.quarter 🍕 on the serviceops board.
jijiki added a subtask: T371360: Apache: Include Wikitech in mw-on-k8s' virtual hosts .Aug 1 2024, 2:09 PM
gerritbot added a comment.Aug 2 2024, 12:21 PM

Change #1059339 had a related patch set uploaded (by Effie Mouzeli; author: Effie Mouzeli):

[operations/mediawiki-config@master] (DNM WIP) wikitech: de-wikitech mediawiki-config

https://gerrit.wikimedia.org/r/1059339

gerritbot added a project: Patch-For-Review.Aug 2 2024, 12:21 PM
jijiki updated the task description. (Show Details)Aug 2 2024, 1:38 PM
gerritbot added a comment.Aug 8 2024, 3:51 PM

Change #1059103 had a related patch set uploaded (by Effie Mouzeli; author: Effie Mouzeli):

[operations/puppet@production] mediawiki: add wikitech to virtual hosts

https://gerrit.wikimedia.org/r/1059103

jijiki changed the task status from Open to In Progress.Aug 8 2024, 3:54 PM
jijiki triaged this task as High priority.
joanna_borun subscribed.Aug 29 2024, 1:12 PM
jijiki renamed this task from MVP: Privately serve wikitech via mw-on-k8s to MVP: Privately serve wikitech via mwdebug1001.Aug 29 2024, 3:04 PM
jijiki updated the task description. (Show Details)
jijiki updated the task description. (Show Details)Aug 29 2024, 3:29 PM
jijiki updated the task description. (Show Details)
gerritbot added a comment.Sep 3 2024, 11:49 AM

Change #1070233 had a related patch set uploaded (by Effie Mouzeli; author: Effie Mouzeli):

[operations/puppet@production] trafficserver: Allow XWD to be used for wikitech

https://gerrit.wikimedia.org/r/1070233

gerritbot added a comment.Sep 3 2024, 1:57 PM

Change #1070233 merged by Effie Mouzeli:

[operations/puppet@production] trafficserver: Allow XWD to be used for wikitech

https://gerrit.wikimedia.org/r/1070233

jijiki updated the task description. (Show Details)Sep 3 2024, 3:05 PM
gerritbot added a comment.Sep 3 2024, 3:07 PM

Change #1070275 had a related patch set uploaded (by Effie Mouzeli; author: Effie Mouzeli):

[performance/WikimediaDebug@master] manifest.json,background.js: Add wikitech.wikimedia.org

https://gerrit.wikimedia.org/r/1070275

jijiki added a subscriber: Ladsgroup.EditedSep 9 2024, 4:08 PM

@Ladsgroup and I tested wikitech.wikimedia.org on mwdebug1001

The following tests worked as expected:

  • Reading and article
  • User Password reset
  • User Login
  • Page Edit

Logs from successful testing can be found in https://logstash.wikimedia.org/goto/ccfa8284b74bd223434b73aceaf2b2a7

Additionally:

  • we believe that if there were jobs spawned, they were executed by our generic jobqueue, but we can verify that in the next test.
  • interaction with mcrouter and memcached work as expected.
jijiki updated the task description. (Show Details)Sep 9 2024, 4:10 PM
Ladsgroup added a comment.Sep 9 2024, 4:23 PM

Regarding jobs, since we don't have an easy control where it'll be consumed, it will use the default wikitech config which means it's going to fail due to ldap not being installed. But I don't see any reason on why we would need to test consumption of the job (queuing it, sure and we did).

jijiki closed this task as Resolved.Sep 10 2024, 4:02 PM

Further testing completed with @Ladsgroup

File upload worked as expected, while jobs where queued, sessions looked alright.

image.png (66×2 px, 33 KB)

For the time being, we believe that our tests are enough. We may close this task and reopen if something surfaces.

jijiki updated the task description. (Show Details)Sep 10 2024, 4:02 PM
jijiki updated the task description. (Show Details)Sep 11 2024, 8:34 AM
gerritbot added a comment.Sep 16 2024, 2:43 PM

Change #1070275 merged by jenkins-bot:

[performance/WikimediaDebug@master] background.js: Allow wikitech.wikimedia.org

https://gerrit.wikimedia.org/r/1070275

dancy subscribed.Tue, Sep 17, 6:34 PM

The updated Firefox add-on is available at https://addons.mozilla.org/en-US/firefox/addon/wikimedia-debug-header/.
The update has been uploaded to Chrome Web Store and is pending processing.

jijiki added a comment.Wed, Sep 18, 2:50 PM
In T371537#10154673, @dancy wrote:

The updated Firefox add-on is available at https://addons.mozilla.org/en-US/firefox/addon/wikimedia-debug-header/.
The update has been uploaded to Chrome Web Store and is pending processing.

Thank you very much!

dancy added a comment.Wed, Sep 18, 4:38 PM

https://chromewebstore.google.com/detail/wikimediadebug/binmakecefompkjggiklgjenddjoifbb?hl=en-US&pli=1 is showing version 2.9.0 so I think that's done too.

bd808 mentioned this in T375795: With XWikimediaDebug enabled, wikitech.wikimedia.org gets redirected to foundation.wikimedia.org until Wikitech is on k8s.Thu, Sep 26, 8:20 PM
gerritbot added a comment.Tue, Oct 1, 10:29 AM

Change #1059103 merged by Effie Mouzeli:

[operations/puppet@production] mediawiki: add wikitech to virtual hosts

https://gerrit.wikimedia.org/r/1059103

gerritbot added a comment.Tue, Oct 1, 10:41 AM

Change #1059339 merged by jenkins-bot:

[operations/mediawiki-config@master] wikitech: de-wikitech mediawiki-config

https://gerrit.wikimedia.org/r/1059339

Stashbot added a comment.Tue, Oct 1, 10:41 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-01T10:41:56Z] <jiji@deploy2002> Started scap sync-world: Backport for [[gerrit:1059339|wikitech: de-wikitech mediawiki-config (T371537 T371592 T371374 T371359)]]

Stashbot mentioned this in T371374: mediawiki-config: consolidate labswiki.Tue, Oct 1, 10:42 AM
Stashbot mentioned this in T371359: Migrate Wikitech's Jobqueue.
Stashbot mentioned this in T371592: LdapAuthentication: Disable extension from Wikitech.
Stashbot added a comment.Tue, Oct 1, 10:44 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-01T10:44:23Z] <jiji@deploy2002> jiji: Backport for [[gerrit:1059339|wikitech: de-wikitech mediawiki-config (T371537 T371592 T371374 T371359)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Tue, Oct 1, 10:52 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-01T10:52:52Z] <jiji@deploy2002> Started scap sync-world: Backport for [[gerrit:1059339|wikitech: de-wikitech mediawiki-config (T371537 T371592 T371374 T371359)]]

Stashbot added a comment.Tue, Oct 1, 10:55 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-01T10:55:17Z] <jiji@deploy2002> jiji: Backport for [[gerrit:1059339|wikitech: de-wikitech mediawiki-config (T371537 T371592 T371374 T371359)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Tue, Oct 1, 11:01 AM

Mentioned in SAL (#wikimedia-operations) [2024-10-01T11:01:16Z] <jiji@deploy2002> Finished scap sync-world: Backport for [[gerrit:1059339|wikitech: de-wikitech mediawiki-config (T371537 T371592 T371374 T371359)]] (duration: 08m 23s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Oct 1, 11:31 AM
jijiki closed subtask T371360: Apache: Include Wikitech in mw-on-k8s' virtual hosts as Resolved.Tue, Oct 1, 12:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits