Page MenuHomePhabricator
Create Task
Maniphest T371904

Rewrite remaining make-container-image code in Python
Closed, ResolvedPublic
Actions

Description

https://gitlab.wikimedia.org/repos/releng/release/-/tree/main/make-container-image consists most of shell scripts and a supporting Python script. Convert it all to Python and simplify the remaining Makefile.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove old image building command for mwbuilder sudooperations/puppetproduction+0 -3
scap.cfg.erb: Update release_repo_build_and_push_images_cmdoperations/puppetproduction+1 -1
Add new image building command for mwbuilder sudooperations/puppetproduction+1 -0
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Aug 6 2024, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2024, 3:17 PM
CodeReviewBot added a comment.Aug 6 2024, 3:40 PM

dancy updated https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/99

Convert remaining image building code to Python

gerritbot added a comment.Aug 6 2024, 3:43 PM

Change #1059942 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] Add new image building command for mwbuilder sudo

https://gerrit.wikimedia.org/r/1059942

gerritbot added a project: Patch-For-Review.Aug 6 2024, 3:43 PM
CodeReviewBot added a comment.Aug 6 2024, 6:11 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/99

Convert remaining image building code to Python

dancy changed the task status from Open to In Progress.Aug 6 2024, 6:12 PM
dancy triaged this task as Medium priority.
Stashbot added a comment.Aug 6 2024, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-06T18:45:22Z] <dancy@deploy1003> Started scap sync-world: testing T371904

Stashbot added a comment.Aug 6 2024, 6:49 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-06T18:49:37Z] <dancy@deploy1003> Finished scap: testing T371904 (duration: 04m 14s)

dancy closed this task as Resolved.Aug 6 2024, 6:52 PM

Deployed to prod and tested.

gerritbot added a comment.Aug 7 2024, 6:37 PM

Change #1059942 merged by Scott French:

[operations/puppet@production] Add new image building command for mwbuilder sudo

https://gerrit.wikimedia.org/r/1059942

CodeReviewBot added a comment.Aug 7 2024, 9:50 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/102

build-images.py: Add command line flags

CodeReviewBot added a comment.Aug 7 2024, 10:24 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/399

kubernetes: Use new way to invoke container image build

gerritbot added a comment.Aug 7 2024, 10:32 PM

Change #1060505 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] scap.cfg.erb: Update release_repo_build_and_push_images_cmd

https://gerrit.wikimedia.org/r/1060505

CodeReviewBot added a comment.Aug 8 2024, 7:00 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/102

build-images.py: Add command line flags

dancy reopened this task as In Progress.Aug 8 2024, 7:03 PM
Stashbot added a comment.Aug 8 2024, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T19:03:21Z] <dancy@deploy1003> Started scap sync-world: testing T371904

Stashbot added a comment.Aug 8 2024, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T19:06:02Z] <dancy@deploy1003> Finished scap: testing T371904 (duration: 02m 40s)

Stashbot added a comment.Aug 8 2024, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T19:20:10Z] <dancy@deploy1003> Started scap sync-world: testing T371904

Stashbot added a comment.Aug 8 2024, 7:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-08T19:31:10Z] <dancy@deploy1003> Started scap sync-world: testing T371904

CodeReviewBot added a comment.Aug 8 2024, 7:35 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/399

kubernetes: Use new way to invoke container image build

dancy mentioned this in rMSCA14879f7460a0: kubernetes: Use new way to invoke container image build.Aug 8 2024, 7:35 PM
CodeReviewBot added a comment.Aug 8 2024, 7:45 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/401

kubernetes: Use new way to invoke container image build

thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team.Aug 8 2024, 9:02 PM
CodeReviewBot added a comment.Aug 12 2024, 7:19 PM

jhuneidi merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/401

kubernetes: Use new way to invoke container image build

jeena mentioned this in rMSCA4acebb212e12: kubernetes: Use new way to invoke container image build.Aug 12 2024, 7:24 PM
gerritbot added a comment.Aug 13 2024, 5:22 PM

Change #1060505 merged by Scott French:

[operations/puppet@production] scap.cfg.erb: Update release_repo_build_and_push_images_cmd

https://gerrit.wikimedia.org/r/1060505

Stashbot added a comment.Aug 13 2024, 5:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-13T17:26:11Z] <swfrench-wmf> run-puppet-agent on deploy1003 to pick up scap.cfg change for T371904

Stashbot added a comment.Aug 13 2024, 5:28 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-13T17:28:52Z] <jhuneidi@deploy1003> Started scap sync-world: testing T371904

Stashbot added a comment.Aug 13 2024, 5:39 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-13T17:39:23Z] <jhuneidi@deploy1003> Finished scap sync-world: testing T371904 (duration: 10m 31s)

gerritbot added a comment.Aug 19 2024, 3:56 PM

Change #1063842 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/puppet@production] Remove old image building command for mwbuilder sudo

https://gerrit.wikimedia.org/r/1063842

CodeReviewBot added a comment.Aug 19 2024, 4:01 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/107

build-images.py: Add --mediawiki-versions flag

CodeReviewBot added a comment.Aug 19 2024, 4:02 PM

dancy opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/405

k8s: Pass the list of live mediawiki versions to build-images.py

CodeReviewBot added a comment.Aug 19 2024, 7:46 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/405

k8s: Pass the list of live mediawiki versions to build-images.py

dancy mentioned this in rMSCA14d765dd7d4d: k8s: Pass the list of live mediawiki versions to build-images.py.Aug 19 2024, 7:47 PM
CodeReviewBot added a comment.Aug 19 2024, 7:52 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/107

build-images.py: Add --mediawiki-versions flag

Stashbot added a comment.Aug 19 2024, 7:53 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-19T19:53:07Z] <dancy@deploy1003> Started scap sync-world: testing T371904

dancy closed this task as Resolved.Aug 19 2024, 7:55 PM
gerritbot added a comment.Aug 19 2024, 8:26 PM

Change #1063842 merged by Scott French:

[operations/puppet@production] Remove old image building command for mwbuilder sudo

https://gerrit.wikimedia.org/r/1063842

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits