Page MenuHomePhabricator

Font size setting should apply consistently across mobile and desktop
Open, Stalled, MediumPublic

Description

Background

The mobile site has had font size controls for much longer than desktop. When originally implemented the font size was scoped so that it only applied to paragraph elements. Given the roll out of desktop font size controls, there is now an open question about why the two behave differently.

User story

As a reader I want....

Requirements

  • The ideal behaviour is the everything in the main content area of an article should scale. If a reader chooses large font size, lists, headings, etc. should also get bigger.

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

Replication case

IMG_9084.png (2×1 px, 585 KB)

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Related Objects

StatusSubtypeAssignedTask
StalledNone
ResolvedDTorsani-WMF
ResolvedDTorsani-WMF
ResolvedDTorsani-WMF
ResolvedDTorsani-WMF
ResolvedAnneT
ResolvedSpikeegardner
ResolvedJdrewniak
ResolvedAnneT
Resolvedgengh
ResolvedVolker_E
Resolvedegardner
Resolvedbmartinezcalvo
ResolvedDTorsani-WMF
OpenNone
ResolvedDTorsani-WMF
ResolvedVolker_E
ResolvedVolker_E
ResolvedAnneT
ResolvedVolker_E
ResolvedVolker_E
ResolvedSpikeAnneT
OpenNone
OpenNone
OpenNone
OpenNone
In ProgressAnneT

Event Timeline

Jdlrobson subscribed.

This might be a duplicate. I think this is intentional but might be being reconsidered so tagging Justin for input.

I could not repro this bug. @Sjoerddebruin are you still able to reproduce this issue?

Jdlrobson renamed this task from MobileFrontend font size setting only affects paragraphs, not lists and other elements to Should font size setting only affects paragraphs in mobile?.Sep 11 2024, 9:43 PM
Jdlrobson updated the task description. (Show Details)

Note: This is not a bug - it was how mobile was intentionally built, so I've updated this as a question.

Jdlrobson triaged this task as Medium priority.Sep 11 2024, 9:43 PM

@JScherer-WMF to review and incorporate into a larger design ticket

The ideal behaviour is the everything in the main content area of an article should scale. If a reader chooses large font size, lists, headings, etc. should also get bigger.

@DTorsani-WMF and DST have been working on this question (T297000). They have developed a font scaling system to achieve this, and I've looked at the system and think it will satisfy the goals of the project. This will bring desktop and mobile in-line with one another, and solve for other issues like the one that @Sjoerddebruin has raised here. This also means that Minerva section headers and their associated icons should also scale with font size preferences. I think this work will continue on their side, so we can remove this task for now.

Jdlrobson renamed this task from Should font size setting only affects paragraphs in mobile? to Font size setting should apply consistently across mobile and desktop.Oct 10 2024, 6:00 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: JScherer-WMF.
Jdlrobson changed the task status from Open to Stalled.Jan 2 2025, 11:31 PM

Stalled on T372653#10162138

@DTorsani-WMF is there an appropriate ticket I should merge this into?

@Jdlrobson This feels like it could fit somewhere alongside T370549: [Spike] Evaluate the decision to expand font size appearance settings outside of the main namespace in MediaWiki which is a product of an overall rethinking of how our type scale functions, which is a semi-product of T363845: [EPIC] Typography scale and font sizing. This spike, T366103: [SPIKE] Font modes for Codex, was also done to evaluate font modes, whose scale was evaluated by the Web team in T369125: Evaluate the design of the revised Codex type scale. @Jdrewniak created the following two spikes to investigate this further, T375934 and T375940. I believe we are hopeful to soon prioritize this work on the Codex side to enable the ability to incorporate this within Web skins, but @CCiufo-WMF can verify that hope.

Thanks. Seems like a duplicate of T363845 to me but I will link them in the mean time.

Jdlrobson-WMF subscribed.

Being proposed for Q4 via our quarterly grooming process.