Page MenuHomePhabricator
Create Task
Maniphest T373001

🙅 Handle "Blocked user" and "Protected entity page" cases
Closed, ResolvedPublic
Actions

Description

  • both cases are currently handled by AssertUserIsAuthorized in our code
  • investigation needed on how to differentiate between the two cases

Details

SubjectRepoBranchLines +/-
REST: Respond with more specific error for blocked usersmediawiki/extensions/Wikibasemaster+74 -8
REST: Respond with more specific error for protected pagesmediawiki/extensions/Wikibasemaster+108 -35
REST: Return result object from PermissionCheckermediawiki/extensions/Wikibasemaster+79 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Wed, Aug 21, 9:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Aug 21, 9:41 AM
Jakob_WMDE claimed this task.Thu, Aug 22, 7:49 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 27) board.
gerritbot added a comment.Thu, Aug 22, 12:41 PM

Change #1064749 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Return result object from PermissionChecker

https://gerrit.wikimedia.org/r/1064749

gerritbot added a project: Patch-For-Review.Thu, Aug 22, 12:42 PM
gerritbot added a comment.Thu, Aug 22, 1:49 PM

Change #1064762 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Respond with more specific error for protected pages

https://gerrit.wikimedia.org/r/1064762

gerritbot added a comment.Thu, Aug 22, 2:43 PM

Change #1064777 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Respond with more specific error for blocked users

https://gerrit.wikimedia.org/r/1064777

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 27) board.Thu, Aug 22, 3:03 PM
gerritbot added a comment.Fri, Aug 23, 3:24 PM

Change #1064749 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Return result object from PermissionChecker

https://gerrit.wikimedia.org/r/1064749

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Fri, Aug 23, 4:00 PM
gerritbot added a comment.Mon, Aug 26, 9:06 AM

Change #1064762 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Respond with more specific error for protected pages

https://gerrit.wikimedia.org/r/1064762

gerritbot added a comment.Mon, Aug 26, 10:48 AM

Change #1064777 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Respond with more specific error for blocked users

https://gerrit.wikimedia.org/r/1064777

Dima_Koushha_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 27) board.Mon, Aug 26, 12:11 PM
Dima_Koushha_WMDE removed a project: Patch-For-Review.
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Sep 3, 9:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits