Page MenuHomePhabricator

Getting zero related data charge warnings on the regular mobile site
Closed, ResolvedPublic


Author: afeldman

When using from my iphone, clicking an image takes me to an imageless page with a "Data charges may apply if you continue" banner.

This is only supposed to be shown on zero, and only on select carriers that aren't zero rating images. This is supposed to be determined by the value of the X-Carrier header which is set by varnish via ip acls but I don't see any use of that header in the deployed or trunk versions of MobileFrontend.

Version: .5
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:18 AM
bzimport set Reference to bz35352.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 10287
Only enables zero rated on file page when $renderZeroRatedBanner set


Changes checked in and are preilly approved. This has now been deployed to production.

Issues is resolved minus some old cached file desc pages.