Page MenuHomePhabricator

The message wikilambda-edit is incorrectly reused for the aria-label in the edit button in the About box
Open, In Progress, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The aria-label for the button in the Hebrew language is "עריכת", which is grammatically incorrect.

What should have happened instead?:

The correct aria-label for this button would be "עריכה". However, it cannot be done because it is inserted using the message wikilambda-edit, which is also used in the heading of function editing pages. Changing this message would make that usage grammatically incorrect.

A new message should be added for this aria-label. It would probably be simply "Edit" (or maybe "edit"). In MediaWiki and extensions, there are already many messages with this text, but a new one should be added anyway. Code re-use is good in many places, but usually not in messages; see https://www.mediawiki.org/wiki/Help:System_message#Avoid_message_re-use .

Other information (browser name/version, screenshots, etc.):

This bug is somewhat related to, but distinct from, T359781.

Event Timeline

Change #1097434 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] i18n: Use a different message for the edit tab and the About widget button

https://gerrit.wikimedia.org/r/1097434

Change #1097434 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] i18n: Use a different message for the edit tab and the About widget button

https://gerrit.wikimedia.org/r/1097434