Maniphest T373827

Log spam from CentralAuthSessionProvider: "username ~2024-XXXX is not usable on this wiki"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I was browsing through channel:session logs looking for a cause of T372702. I didn't find that, but I found this instead.

We have ~1500 warnings logged per day, starting on 2024-07-22, that look like this:
CentralAuthSessionProvider::provideSessionInfo: username ~2024-XXXX is not usable on this wiki

https://logstash.wikimedia.org/goto/25a50e3951f929a265ede5df1f7dea43

It's good that it's not usable (this is getting logged on wikis with temp accounts disabled). CentralAuth shouldn't log these warnings for temporary users.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	[session] Don't create a warning if name reserved by temp user system	Dreamy Jazz	mediawiki/extensions/CentralAuth	master	+17 -5

Customize query in gerrit

Related Objects

Mentioned Here: T372702: editors are repeatedly getting logged out (August 2024)

Event Timeline

• matmarex created this task.Sep 2 2024, 10:02 PM

Herald added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptSep 2 2024, 10:02 PM

Herald added a subscriber: Aklapper. · View Herald Transcript

JJMC89 removed a project: Wikimedia-production-error.Sep 2 2024, 10:14 PM

• matmarex edited projects, added: Trust and Safety Product Team, MediaWiki-Core-Platform-Team (Radar); removed: MediaWiki-Core-Platform-Team.Sep 9 2024, 3:01 PM

Thanks for filing this. Tagging this as a pilot wiki blocker as the rate of logstash entries would increase once we deploy to more wikis.

Dreamy_Jazz claimed this task.Sep 10 2024, 5:26 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Change #1071929 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] [session] Don't create a warning if name reserved by temp user system

https://gerrit.wikimedia.org/r/1071929

gerritbot added a project: Patch-For-Review.Sep 10 2024, 6:01 PM

Dreamy_Jazz moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 10 2024, 6:32 PM

Suggested testing steps:

Use a MediaWiki-extensions-CentralAuth wiki farm for testing
Enable temporary accounts on one wiki (wiki A) and then have them disabled on another wiki (wiki B)
Create a temporary account on wiki A
Open wiki B while logged in to the temporary account
Verify that no warning is logged on wiki B for the username of the temporary account not being usable

This may instead be easier to test when this reaches production wikis.

Change #1071929 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] [session] Don't create a warning if name reserved by temp user system

https://gerrit.wikimedia.org/r/1071929

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 10 2024, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2024, 7:30 PM

kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 16 2024, 8:41 AM

Dreamy_Jazz moved this task from Sprint Theremin (Aug 26 - Sept. 6) to Sprint Beatboxing (Sept 16-27) on the Trust and Safety Product Sprint board.Sep 16 2024, 10:16 AM

Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.

Dreamy_Jazz moved this task from Sprint Beatboxing (Sept 16-27) to Sprint Cello (Oct 7 - 18) on the Trust and Safety Product Sprint board.Oct 8 2024, 10:13 AM

Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.

In discussion with @Djackson-ctr, this will be hard to QA locally and QA on production would be difficult for them as they do not have logstash access.

I've checked that https://logstash.wikimedia.org/goto/25a50e3951f929a265ede5df1f7dea43 no longer shows any such log since the patch was deployed to all wikis. The link shows no such logs since the 19th of September.

Dreamy_Jazz closed this task as Resolved.Oct 9 2024, 8:59 AM