Page MenuHomePhabricator
Create Task
Maniphest T374051

Pending Transaction Resolver support for Gravy
Closed, ResolvedPublic
Actions

Description

We already resolve Adyen's transactions, so the code should mostly be there. We need to check if any gravy-specific flags need adding.

Details

SubjectRepoBranchLines +/-
Add tests to cover Gravy pending transaction resolver pathswikimedia/fundraising/crmmaster+833 -0
Upgrade SmashPig to v0.8.13wikimedia/fundraising/crmmaster+8 -8
Update call to get Gravy transaction detailsmediawiki/extensions/DonationInterfacemaster+1 -1
Switch getPaymentDetails to getLatestPaymentStatus on Gravy PaymentProcessorwikimedia/fundraising/SmashPigmaster+20 -19
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT364501 Gravy Integration
 ResolvedjgleesonT374051 Pending Transaction Resolver support for Gravy

Event Timeline

jgleeson created this task.Sep 4 2024, 6:12 PM
AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 9 2024, 8:26 PM
AKanji-WMF moved this task from Sprint +1 to Next on the Fundraising-Backlog board.Sep 10 2024, 7:10 PM
jgleeson claimed this task.Sep 24 2024, 12:00 PM
jgleeson added a project: Fundraising Sprint: reasonablyAccurate().
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint: reasonablyAccurate() board.Sep 24 2024, 12:02 PM
AKanji-WMF moved this task from Next to Current Sprint on the Fundraising-Backlog board.Sep 24 2024, 8:05 PM
AKanji-WMF edited projects, added Fundraising Sprint: Sssss; removed Fundraising Sprint: reasonablyAccurate().Sep 24 2024, 11:17 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint: Sssss board.Sep 25 2024, 1:34 PM
jgleeson added a comment.Sep 25 2024, 1:46 PM

I've tested this locally with a Gravy payment stopped at auth, and it currently fails due to the Gravy PaymentProvider class not supporting getLatestPaymentStatus, so we'll need to update the Gravy Smashpig code to support that first.

gerritbot added a comment.Sep 25 2024, 3:35 PM

Change #1075590 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/SmashPig@master] Switch getPaymentDetails to getLatestPaymentStatus on Gravy PaymentProcessor

https://gerrit.wikimedia.org/r/1075590

gerritbot added a project: Patch-For-Review.Sep 25 2024, 3:35 PM
jgleeson moved this task from Doing to Ready for Review on the Fundraising Sprint: Sssss board.Sep 25 2024, 6:55 PM
jgleeson added a comment.EditedSep 25 2024, 6:58 PM

The pending transaction resolver is now working for me locally with Gravy transactions after checking out this SmashPig patch into CiviCRM using ./scripts/civicrm-smashpig-checkout-patch.sh 1075590
Note: mac users must also run ./setup.sh sync to push the updates to your CiviCRM container.

gerritbot added a comment.Sep 26 2024, 9:30 PM

Change #1075590 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Switch getPaymentDetails to getLatestPaymentStatus on Gravy PaymentProcessor

https://gerrit.wikimedia.org/r/1075590

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2024, 9:30 PM
AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Sssss board.Sep 26 2024, 9:39 PM
gerritbot added a comment.Sep 30 2024, 3:33 PM

Change #1076786 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Update call to get Gravy transaction details

https://gerrit.wikimedia.org/r/1076786

gerritbot added a project: Patch-For-Review.Sep 30 2024, 3:33 PM
gerritbot added a comment.Sep 30 2024, 4:51 PM

Change #1076786 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Update call to get Gravy transaction details

https://gerrit.wikimedia.org/r/1076786

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 30 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2024, 5:30 PM
gerritbot added a comment.Oct 2 2024, 1:53 PM

Change #1077393 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Add tests to cover Gravy pending transaction resolver paths

https://gerrit.wikimedia.org/r/1077393

gerritbot added a project: Patch-For-Review.Oct 2 2024, 1:53 PM
jgleeson moved this task from Pending Deployment to Ready for Review on the Fundraising Sprint: Sssss board.Oct 2 2024, 4:06 PM
gerritbot added a comment.Oct 2 2024, 6:39 PM

Change #1077454 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Upgrade SmashPig to v0.8.13

https://gerrit.wikimedia.org/r/1077454

gerritbot added a comment.Oct 2 2024, 8:41 PM

Change #1077454 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Upgrade SmashPig to v0.8.13

https://gerrit.wikimedia.org/r/1077454

gerritbot added a comment.Oct 2 2024, 9:15 PM

Change #1077393 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add tests to cover Gravy pending transaction resolver paths

https://gerrit.wikimedia.org/r/1077393

jgleeson moved this task from Ready for Review to Done on the Fundraising Sprint: Sssss board.Oct 3 2024, 9:16 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 3 2024, 9:30 PM
XenoRyet closed this task as Resolved.Oct 7 2024, 7:22 PM
XenoRyet set Final Story Points to 4.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits