Page MenuHomePhabricator

Debug parameters don't work as expected
Closed, ResolvedPublic

Description

Author: reha

Description:
[From Fabrice, 3/21]

Debug parameters don't work as expected:

  • (high priority) Cannot use a direct link to force one option to display in debug mode, as so:

http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=1&debug=true&aftv5_link=E

  • However, if you set debug to 'false', you can cause it to do what it should do:

http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=1&debug=false&aftv5_link=E

  • It's also not clear how to force the *actual* bucketing: it looks like the "bucket" parameter is used to switch to a different design but it doesn't rebucket me in a different condition: that's not what I would expect.
  • It is still possible to access the old feedback forms, either based on a 'previous bucket' cookie or by entering a link such as this one:

http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=2&debug=false&aftv5_link=E


Version: unspecified
Severity: normal

Details

Reference
bz35414

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:11 AM
bzimport set Reference to bz35414.

reha wrote:

This appears to have been a caching issue. I'm able to use the aftv5_link parameter with debug=true to select link options.

The "bucket" parameter is a holdover from the early days of AFTv5, when the only thing being bucketed was form display options -- the form options are named "bucket" throughout the code. While that's not ideal, the risk involved with a manual change on this sort of scale is quite high, and the benefit is very small.

An alternative would be for me to rename only the url parameter, or to remove it entirely.

See https://www.mediawiki.org/wiki/Article_feedback/Version_5/Technical_Design#Debug_state_and_query_string_options for how the url parameters are meant to work.

reha wrote:

Note also that when using the url parameters, you have access to all of the form options that are in the javascript, regardless of what is being shown to normal users.

Given that Option 1 has been chosen moving forward, I think it's probably time to remove all of the other options from the javascript -- it will shrink the file significantly, which is always good for load time.

reha wrote:

Reassigning to Fabrice for his input.

reha wrote:

Punting back to Yoni (protocol!)

Mentioned in SAL (#wikimedia-operations) [2024-09-09T13:58:34Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071251|Define wgCheckUserCentralIndexRangesToExclude to exclude WMCS (T373021)]], [[gerrit:rEWBA1071253a7fd3|tests: Disable all Beta Cluster CI testing, all failing (T374242)]], [[gerrit:1071254|Don't pass empty type/returnType to zobject lookup when undefined (T374199)]], [[gerrit:1071265|Use default width/height on gallery to avoid parser instance (T37414