Page MenuHomePhabricator

DBQueryError in Special:Impact (old) module
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Force the user variant to be oldimpact
  • Navigate to Special:Impact

What happens?:

An error is thrown:

[efa9e4ff4f78798405786690] /w/index.php?title=Special:Impact/Alice-j5mSkpQkl0 Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading or after adding a new extension?

Please see https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Upgrading and https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:How_to_debug for more information.

Error 1055: 'latest_edits.page_title' isn't in GROUP BY
Function: GrowthExperiments\HomepageModules\Impact::queryArticleEdits
Query: SELECT rev_page,page_title,page_namespace,MAX(rev_timestamp) AS `max_ts`,MIN(rev_timestamp) AS `min_ts` FROM (SELECT rev_page,page_title,page_namespace,rev_timestamp FROM `revision` JOIN `page` ON ((rev_page = page_id)) WHERE ((rev_actor = 319)) AND rev_deleted = 0 AND page_namespace = 0 ORDER BY rev_timestamp DESC LIMIT 1000 ) `latest_edits` GROUP BY rev_page ORDER BY max_ts DESC LIMIT 10
Backtrace:

from /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/Database.php(1193)
#0 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/Database.php(1177): Wikimedia\Rdbms\Database->getQueryException(string, int, string, string)
#1 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/Database.php(1151): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, int, string, string)
#2 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/Database.php(643): Wikimedia\Rdbms\Database->reportQueryError(string, int, string, string, bool)
#3 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/Database.php(1340): Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#4 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#5 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(351): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /Users/sergio/src/mediawiki/w/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(745): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#7 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/HomepageModules/Impact.php(614): Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
#8 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/HomepageModules/Impact.php(547): GrowthExperiments\HomepageModules\Impact->queryArticleEdits()
#9 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/HomepageModules/Impact.php(522): GrowthExperiments\HomepageModules\Impact->getArticleContributions()
#10 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(214): GrowthExperiments\HomepageModules\Impact->getState()
#11 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/DashboardModule/DashboardModule.php(197): GrowthExperiments\HomepageModules\BaseModule->outputDependencies()
#12 /Users/sergio/src/mediawiki/w/extensions/GrowthExperiments/includes/Specials/SpecialImpact.php(121): GrowthExperiments\DashboardModule\DashboardModule->render(string)
#13 /Users/sergio/src/mediawiki/w/includes/specialpage/SpecialPage.php(719): GrowthExperiments\Specials\SpecialImpact->execute(string)
#14 /Users/sergio/src/mediawiki/w/includes/specialpage/SpecialPageFactory.php(1708): MediaWiki\SpecialPage\SpecialPage->run(string)
#15 /Users/sergio/src/mediawiki/w/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#16 /Users/sergio/src/mediawiki/w/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#17 /Users/sergio/src/mediawiki/w/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#18 /Users/sergio/src/mediawiki/w/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#19 {main}

What should have happened instead?:
No error should happen, or the new impact module should be shown, see T350077: Drop support for the old Impact module

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):