Page MenuHomePhabricator

Blocks appear to succeed even if query fails due to wrong DB structure
Closed, ResolvedPublic

Description

When testing gerrit change 3841 noticed that when I forgot to run update.php
the query fails as expected:

Query trunk (90) (slave): INSERT /* Block::insert Saper */ INTO "ipblocks" (ipb_address,ipb_user,ipb_by,ipb_by_text,ipb_reason,ipb_timestamp,ipb_auto,ipb_anon_only,ipb_create_account,ipb_enable_autoblock,ipb_expiry,ipb_range_start,ipb_range_end,ipb_deleted,ipb_block_email,ipb_allow_usertalk,ipb_cause,ipb_id) VALUES ('Test5','2','1','Saper','Bez autoblock','2012-03-28 18:50:57 GMT','0',0,0,0,'2012-03-29 18:50:57 GMT','','','0',0,0,NULL,'137')
Query trunk (91) (slave): ROLLBACK
SQL ERROR (ignored): ERROR: column "ipb_cause" of relation "ipblocks" does not exist
LINE 1: ...nd,ipb_deleted,ipb_block_email,ipb_allow_usertalk,ipb_cause,...

^

Query trunk (92) (slave): BEGIN
Transaction state changed from IDLE -> TRANS

But the error is ignored due to generic workaround for errors encountered during INSERT IGNORE. (This one is from Block.php:444).

The MediaWiki says then everything is OK and even this block gets logged in the log, but is not active.

HOW TO REPRODUCE:

Apply gerrit change 3841 patchset 3 to 8824515e571eadd4a63b09e1331f35309315603f
and try to block some user. The query will fail but MediaWiki says all is fine.

PROPOSED FIX:

I would propose to narrow down ignorable query failures only to violations of primary keys.

Another thing is it would be good to check if log entry gets rollbacked too in case of fatal error.


Version: 1.20.x
Severity: major
URL: https://gerrit.wikimedia.org/r/#change,3841,patchset=3

Details

Reference
bz35572

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:11 AM
bzimport added a project: Wikimedia-Rdbms.
bzimport set Reference to bz35572.
bzimport added a subscriber: Unknown Object (MLST).
saper created this task.Mar 28 2012, 7:31 PM
saper added a comment.Mar 30 2012, 3:21 AM

Fixed in gerrit change 3977

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.