Make it clear that cross-wiki permission checking in Special:GlobalContributions is not ideal
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It does this by making API calls to the other wikis, since there is no better way yet to check cross-wiki permissions. This is not ideal, because:

Making API calls is slow, so it increases page load time
API calls may fail (in which case we just assume they don't have the permissions)

Although we can't improve on this yet, we should make it clear that this is a hack.

Add comments in the code that make it clear that using the API calls is a hack and not ideal.
File a task to make platform improvements in cross-wiki permission checking, and cite that task in the comments.

	Subject	Repo	Branch	Lines +/-
	Add comments to explain that API permissions lookups are not ideal	mediawiki/extensions/CheckUser	master	+4 -0

Mentioned In: T356294: Restrict which groups have access to Special:GlobalContributions
Mentioned Here: T380867: Allow looking up permissions directly across multiple wikis
T356294: Restrict which groups have access to Special:GlobalContributions

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2024, 6:51 PM

Tchanders set the point value for this task to 1.

Change #1098039 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add comments to explain that API permissions lookups are not ideal

Add comments in the code that make it clear that using the API calls is a hack and not ideal.

File a task to make platform improvements in cross-wiki permission checking, and cite that task in the comments.

Change #1098039 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add comments to explain that API permissions lookups are not ideal

Tchanders closed this task as Resolved.Wed, Dec 4, 6:45 PM