Page MenuHomePhabricator

TemplateStyles fails on MW 1.43 with "ArgumentCountError: Too few arguments to function Wikimedia\ScopedCallback::consume()"
Closed, DuplicatePublic

Description

sudo -u www-data php /srv/mediawiki/1.43/maintenance/run.php /srv/mediawiki/1.43/extensions/MirahezeMagic/maintenance/mergeMessageFileList.php --quiet --wiki=metawikibeta --extensions-dir=/srv/mediawiki/1.43/extensions:/srv/mediawiki/1.43/skins --output /srv/mediawiki/config/ExtensionMessageFiles-1.43.php

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Wikimedia\ScopedCallback::consume(), 0 passed in /srv/mediawiki/1.43/vendor/wikimedia/services/src/ServiceContainer.php on line 461 and exactly 1 expected in /srv/mediawiki/1.43/extensions/TemplateStyles/vendor/wikimedia/scoped-callback/src/ScopedCallback.php:57
Stack trace:
#0 /srv/mediawiki/1.43/vendor/wikimedia/services/src/ServiceContainer.php(461): Wikimedia\ScopedCallback::consume()
#1 /srv/mediawiki/1.43/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService('BootstrapConfig')
#2 /srv/mediawiki/1.43/includes/MediaWikiServices.php(357): Wikimedia\Services\ServiceContainer->getService('BootstrapConfig')
#3 /srv/mediawiki/1.43/includes/MediaWikiServices.php(852): MediaWiki\MediaWikiServices->getService('BootstrapConfig')
#4 /srv/mediawiki/1.43/includes/ServiceWiring.php(944): MediaWiki\MediaWikiServices->getBootstrapConfig()
#5 /srv/mediawiki/1.43/vendor/wikimedia/services/src/ServiceContainer.php(445): Wikimedia\Services\ServiceContainer::{closure}(Object(MediaWiki\MediaWikiServices))
#6 /srv/mediawiki/1.43/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService('HookContainer')
#7 /srv/mediawiki/1.43/includes/MediaWikiServices.php(357): Wikimedia\Services\ServiceContainer->getService('HookContainer')
#8 /srv/mediawiki/1.43/includes/MediaWikiServices.php(1195): MediaWiki\MediaWikiServices->getService('HookContainer')
#9 /srv/mediawiki/1.43/includes/exception/MWExceptionHandler.php(796): MediaWiki\MediaWikiServices->getHookContainer()
#10 /srv/mediawiki/1.43/includes/exception/MWExceptionHandler.php(749): MWExceptionHandler::callLogExceptionHook(Object(ArgumentCountError), false)
#11 /srv/mediawiki/1.43/includes/exception/MWExceptionHandler.php(197): MWExceptionHandler::logException(Object(ArgumentCountError), 'mwe_handler')
#12 /srv/mediawiki/1.43/includes/exception/MWExceptionHandler.php(238): MWExceptionHandler::rollbackPrimaryChangesAndLog(Object(ArgumentCountError), 'mwe_handler')
#13 /srv/mediawiki/1.43/includes/exception/MWExceptionHandler.php(207): MWExceptionHandler::handleException(Object(ArgumentCountError), 'mwe_handler')
#14 [internal function]: MWExceptionHandler::handleUncaughtException(Object(ArgumentCountError))
#15 {main}
  thrown in /srv/mediawiki/1.43/extensions/TemplateStyles/vendor/wikimedia/scoped-callback/src/ScopedCallback.php on line 57

This seems to be because TemplateStyles is installing version 5 of scoped-callback, even tho mw core does not use version 5 and the extension on that branch shouldn't be using that version as we have it set at 4.0.

Event Timeline

Restricted Application added subscribers: Reception123, Aklapper. · View Herald Transcript

Think this will impact MW 1.42 as well?

Change #1088709 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/extensions/TemplateStyles@master] Pin wikimedia/scoped-callback to 4.0.0

https://gerrit.wikimedia.org/r/1088709

Change #1088710 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/extensions/CSS@master] Pin wikimedia/scoped-callback to 4.0.0

https://gerrit.wikimedia.org/r/1088710