Page MenuHomePhabricator

Skip final resolution of instances of Wikidata types
Closed, ResolvedPublic

Description

Description

Since instances of Wikidata types are constructed automatically by orchestrator code, which checks the validity of the JSON content retrieved from Wikidata, it's inessential for the orchestrator to perform the extra recursive resolution step.

It should be possible to eliminate this step by marking the ZWrappers for these instances as "fully resolved", and checking this flags before running the resolution step.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • We expect this to improve performance whenever the orchestrator fetches Wikidata content of a nontrivial size.

Event Timeline

Change #1117551 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-28-144249 to 2025-02-03-215824

https://gerrit.wikimedia.org/r/1117551

Change #1117551 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-28-144249 to 2025-02-03-215824

https://gerrit.wikimedia.org/r/1117551

@cmassaro Could you please check if this task had the expected impact on performance and "resolve" it if that is the case?

Yes, happy to resolve. This did indeed have the expected impact on performance. Calls that were taking ~7 seconds are now taking <1 second.

Change #1119094 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-11-155417.

https://gerrit.wikimedia.org/r/1119094

Change #1119094 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-11-155417.

https://gerrit.wikimedia.org/r/1119094