Page MenuHomePhabricator

Deduplicate Fetching Logic in src/db.js
Closed, ResolvedPublic

Description

Description

The dereferenceZObjects and retrieveWikidataEntity functions should converge into a single fetching function. This way, improvements to one (like caching and pre-caching) will automatically be extended to both wikilambda_fetch and wikidata calls.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • create separate cache and pre-cache for Wikidata items
  • collapse dereferenceZObjects and retrieveWikidataEntity logic into a single underlying function to share fetching, caching, and pre-caching logic

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task


Completion checklist

Event Timeline

cmassaro added a subscriber: DMartin-WMF.

Reassigning after discussion with David, thank you!

Change #1111626 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-08-142250 to 2025-01-15-052609

https://gerrit.wikimedia.org/r/1111626

Change #1111626 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-08-142250 to 2025-01-15-052609

https://gerrit.wikimedia.org/r/1111626

Change #1115028 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115028

Change #1115032 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115032

Change #1115032 abandoned by Cory Massaro:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

Reason:

already done

https://gerrit.wikimedia.org/r/1115032

Change #1115028 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115028