Page MenuHomePhabricator

HTMLForm textarea field does not support 'placeholder'
Closed, ResolvedPublic

Description

While the 'text' form field supports the 'placeholder' tag, 'textarea' does not.


Version: unspecified
Severity: normal

Details

Reference
bz36049

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:20 AM
bzimport set Reference to bz36049.
bzimport added a subscriber: Unknown Object (MLST).

Platonides brought up an excellent point in code review in regards to an oversight I made when doing:
if ( !empty( $this->mParams['placeholder'] ) ) {

			$attribs['placeholder'] = $this->mParams['placeholder'];
		}

He said:
"What if the placeholder was a 0 ?"

This should probably be handled with isset() rather than !empty().