Page MenuHomePhabricator
Create Task
Maniphest T381188

Missing spacing between footer and buttons
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
mszabo
Authored By
KColeman-WMF
Fri, Nov 29, 10:11 PM
Tags
Referenced Files
F57780111: image.png
Thu, Dec 5, 7:53 AM
F57779609: image.png
Thu, Dec 5, 7:53 AM
F57762127: footer-spacing.png
Fri, Nov 29, 10:11 PM
Subscribers
Aklapper
Djackson-ctr
KColeman-WMF
kostajh

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • There is no spacing between footer and buttons

What should have happened instead?:
According to dialog specs:

  • Desktop add spacing-50 / 8px between footer and buttons
  • Mobile add spacing-75 / 12px between footer and buttons

Supporting images:

footer-spacing.png (1×1 px, 194 KB)

Details

SubjectRepoBranchLines +/-
dialog: Fix footer spacingmediawiki/extensions/ReportIncidentmaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

KColeman-WMF created this task.Fri, Nov 29, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 29, 10:11 PM
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Sun, Dec 1, 8:07 PM
kostajh subscribed.Mon, Dec 2, 9:26 AM

Probably caused by rEREIb2d1eaed445e: dialog: Don't stack buttons on mobile. I think we need to add the margin-top back from that patch.

mszabo changed the task status from Open to In Progress.Mon, Dec 2, 12:04 PM
mszabo claimed this task.
mszabo moved this task from Backlog to In progress on the Incident-Reporting-System (Pilot wiki release December 2024) board.
mszabo moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.
mszabo removed a subscriber: Aklapper.
gerritbot added a comment.Mon, Dec 2, 2:11 PM

Change #1099702 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/ReportIncident@master] dialog: Fix footer spacing

https://gerrit.wikimedia.org/r/1099702

gerritbot added a project: Patch-For-Review.Mon, Dec 2, 2:11 PM
mszabo moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Mon, Dec 2, 2:52 PM
Aklapper added a project: CSS.Mon, Dec 2, 9:19 PM
Aklapper subscribed.
gerritbot added a comment.Mon, Dec 2, 9:48 PM

Change #1099702 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] dialog: Fix footer spacing

https://gerrit.wikimedia.org/r/1099702

mszabo mentioned this in rEREI8dd223c6fc2a: dialog: Fix footer spacing.Mon, Dec 2, 9:49 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Mon, Dec 2, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Dec 2, 10:29 PM
mszabo moved this task from In progress to Done / QA on the Incident-Reporting-System (Pilot wiki release December 2024) board.Tue, Dec 3, 12:18 AM
mszabo moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Thu, Dec 5, 7:53 AM
Djackson-ctr subscribed.

QA is completed...
Spacing has been applied between Footer and Buttons.

image.png (449×653 px, 39 KB)

image.png (884×476 px, 205 KB)

kostajh closed this task as Resolved.Thu, Dec 5, 12:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits