Page MenuHomePhabricator

PageTriage should recognize the difference between a patrol action and an autopatrol action
Closed, ResolvedPublic

Description

ClueBotNG appears as the top reviewer. This is kinda impressive, cuz ClueBot is, well, a bot, and doesn't patrol :P.

The problem appears to be that the mechanism doesn't distinguish between patrols and autopatrols, and cluebot creates-and-patrols a lot of IP talkpages.


Version: unspecified
Severity: normal

Details

Reference
bz36837

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:23 AM
bzimport added a project: PageTriage.
bzimport set Reference to bz36837.
bzimport added a subscriber: Unknown Object (MLST).

The correct way for us to fix this is probably to add a new field to pagetriage_log indicating the natural of the action: autopatrol, newpages, or pagetriage. This is not a trivial fix, however, and will require some planning. In the meantime, we could just exclude bots completely, if you think that makes sense. We could actually do that before the deployment today.

bsitu wrote:

Status difference fix: https://gerrit.wikimedia.org/r/#/c/10675/
Top reviewer stats fix: https://gerrit.wikimedia.org/r/#/c/11129/

Upon deployment, existing data should be flushed as they have incorrect status

bsitu wrote:

We introduced patrolled, auto-patrolled status in today's deployment and I have removed the != 'ClueBot' check from the stat query. Since the old records will still have auto-patrolled status as reviewed, 'ClueBot' may appear again as top reviewer, this is not a bug. Since the stat looks back at 7 days, 'ClueBot' will be gone from the list in at most 7 days or we can go ahead and remove all existing data.

bsitu wrote:

Marking this as fixed because code has been deployed to production and haven't seen any odd behaviour