Page MenuHomePhabricator

Division by zero in /includes/ImagePage.php
Closed, ResolvedPublic

Description

Warning: Division by zero in /usr/local/apache/common-local/php-1.20wmf3/includes/ImagePage.php on line 344


Version: unspecified
Severity: normal

Details

Reference
bz36911
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
jobs-api: bump to 0.0.420-20250925165253-31f66be8repos/cloud/toolforge/toolforge-deploy!980group_203_bot_f4d95069bb2675e4ce1fff090c1c1620bump_jobs-apimain
[quota] inc deprecated counter for quota requestsrepos/cloud/toolforge/jobs-api!181raymond-ndibeinc_deprecation_counter_for_quotamain
jobs-api: bump to 0.0.378-20250522194547-6776b4dbrepos/cloud/toolforge/toolforge-deploy!794group_203_bot_f4d95069bb2675e4ce1fff090c1c1620bump_jobs-apimain
[jobs-api] refactor quota modelsrepos/cloud/toolforge/jobs-api!164raymond-ndiberefactor_quotamain
jobs-api: bump to 0.0.373-20250512184826-3b202d92repos/cloud/toolforge/toolforge-deploy!778group_203_bot_f4d95069bb2675e4ce1fff090c1c1620bump_jobs-apimain
d/changelog: bump to 16.1.12repos/cloud/toolforge/jobs-cli!102dcarobump_jobs-climain
[jobs-cli] refactor job payloadrepos/cloud/toolforge/jobs-cli!98raymond-ndiberefactor_job_payloadmain
[jobs-api] split job models to oneoff, scheduled and continuousrepos/cloud/toolforge/jobs-api!154raymond-ndibesplit_new_job_modelmain
[jobs-cli] quota refactorrepos/cloud/toolforge/jobs-cli!97raymond-ndibehealth_check_and_quota_refactormain
[jobs-cli] only send timeout if it's set by the userrepos/cloud/toolforge/jobs-cli!96raymond-ndibeschedule_timeout_default_Nonemain
d/changelog: bump to 16.1.10repos/cloud/toolforge/jobs-cli!95raymond-ndibebump_jobs-climain
jobs-api: bump to 0.0.363-20250407065250-1453d60erepos/cloud/toolforge/toolforge-deploy!738ghostbump_jobs-apimain
[jobs-api] move custom validations out of api modelsrepos/cloud/toolforge/jobs-api!150raymond-ndibemove_most_custom_validations_out_of_api_modelsmain
[jobs-cli] use imagename in definedjobrepos/cloud/toolforge/jobs-cli!90raymond-ndibeuse_imagename_in_defined_jobmain
[jobs-api] refactor imagename field in modelsrepos/cloud/toolforge/jobs-api!149raymond-ndiberefactor_imagename_field_in_modelsmain
[jobs-api] use pydantic for all modelsrepos/cloud/toolforge/jobs-api!139raymond-ndibeuse_pydantic_for_core_job_modelmain
Show related patches Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:28 AM
bzimport set Reference to bz36911.
bzimport added a subscriber: Unknown Object (MLST).

1 Warning: Division by zero in /usr/local/apache/common-local/php-1.20wmf3/includes/ImagePage.php on line 344

1 Warning:  Division by zero in /usr/local/apache/common-local/php-1.20wmf3/includes/ImagePage.php on line 343
1 Warning:  Division by zero in /usr/local/apache/common-local/php-1.20wmf3/includes/ImagePage.php on line 338

PHP Warning: Division by zero in /usr/local/apache/common-local/php-1.21wmf5/includes/ImagePage.php on line 349

As these lines are moving, and to make it more apparent... FIXME comments left in https://gerrit.wikimedia.org/r/#/c/37344/

8 PHP Warning:  Division by zero in /usr/local/apache/common-local/php-1.21wmf5/includes/ImagePage.php on line 348
8 PHP Warning:  Division by zero in /usr/local/apache/common-local/php-1.21wmf5/includes/ImagePage.php on line 343
7 PHP Warning:  Division by zero in /usr/local/apache/common-local/php-1.21wmf5/includes/ImagePage.php on line 349

Looks like my 344 commentone is extra, but no harm in being safe!

Other than the hilariousness of division by zero errors, I'm unsure what the actual significance of this is to the end user. Setting to low.

Change 134855 had a related patch set uploaded by Brian Wolff:
Make SVG files show "In other resolutions" at all sizes

https://gerrit.wikimedia.org/r/134855

Change 134855 merged by jenkins-bot:
Make SVG files show "In other resolutions" at all sizes

https://gerrit.wikimedia.org/r/134855