Page MenuHomePhabricator

jquery.suggestions should obey maxRows setting
Closed, ResolvedPublic


Author: john

jQuery.suggestions has a maxRows property however it is never used and therefore has no effect.

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:25 AM
bzimport set Reference to bz37316.
bzimport added a subscriber: Unknown Object (MLST).

Note that the jquery.suggestions plugin (afaik) is no longer maintained and was temporarily developed by the Usability Initiative when jquery.ui.autocomplete had issues. This is no longer the case and most if not all scripts are now using jquery.ui.autocomplete. And when not already, they should be changed to use that so we can remove this old module.

jquery.suggestions is still used, most notably for the search suggestions dropdown in all skins. There was some other module that was killed off a long time ago, you must have meant that.

The "default" for the unused option is currently 7… I'd change this to 10 if this bug is fixed, to reflect what the actual limit for the search suggestions is right now. (Or just fix this in that particular instance.)

Change 182642 had a related patch set uploaded (by Unicodesnowman):
Make jquery.suggestions obey maxRows setting


Krinkle raised the priority of this task from Lowest to Medium.Jan 5 2015, 1:19 AM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).

Change 182642 merged by jenkins-bot:
Make jquery.suggestions obey maxRows setting

matmarex assigned this task to Unicodesnowman.
matmarex removed a project: Patch-For-Review.