Page MenuHomePhabricator

Can't selectively undelete revisions with same timestamp
Open, NormalPublic

Description

While importing https://commons.wikimedia.org/w/index.php?title=Template:Key_press/doc&action=history something went wrong: The last 10 revs were imported twice. Of course I tried to delete them (revdel). But this always looks like hiding something from the normal user and just creates curiosity. Therefore I deleted the whole page and attempted to restore only some of the revisions (the non-dupe ones). This didn't work. Even when selecting only one revision to undelete, the revision by the same user&timestamp are undeleted.

Timestamp based revision deleting (evidence, HTML excerpt: <input type="checkbox" value="1" name="ts20111227115020">) and restoring should be banned from MediaWiki. This should work ID-based. This also for image-revision deleting/restoring.

Feel free to split or retarget this bug, as you like.


Version: unspecified
Severity: normal

Details

Reference
bz37465

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 12:25 AM
bzimport set Reference to bz37465.
bzimport added a subscriber: Unknown Object (MLST).
Rillke created this task.Jun 11 2012, 3:26 PM

With the new behavior for moving pages over redirects, this bug definitely needs to be fixed. When page A is moved to B, then page B is moved back to A and page A is deleted, both the null edit and the redirect creation resulting from the move from A to B would appear in the deleted edits of page A and, with rare exceptions, would usually have the same timestamp. You wouldn't want the redirect creation to be undeleted, but due to this bug, undeleting the null edit would force the redirect creation to be undeleted as well. Since revision 748614368 of page Tahli, Dasuya on Wikipedia was not undeleted, this implies that revision 748614368 cannot have the same timestamp as revision 748614367, making it one of the rare exceptions.

Change 337213 had a related patch set uploaded (by GeoffreyT2000):
Use revision ids instead of timestamps for undeletion

https://gerrit.wikimedia.org/r/337213

Change 337213 abandoned by GeoffreyT2000:
Use revision ids instead of timestamps for undeletion

Reason:
PageArchive has been moved to its own separate file. Besides, I do not know how to fix everything here, so I am abandoning this for now.

https://gerrit.wikimedia.org/r/337213