Page MenuHomePhabricator

VisualEditor: bullet list breaking after changing window focus
Closed, ResolvedPublic

Description

Author: dbaran

Description:
Browser = Chrome 19.0.1084.56

Clickstream:

--used formatting toolbar to select bullet
--entered single word
--changed focus from browser to different window (skype I think)
--changed focus back to browser by mousing back to bullet list
--hit enter
--nothing happened. cursor didn't move.

I can reproduce consistently by typing in another window, then coming back to browser, and cursor will be stuck. However if I perform some action in another tab of the browser, when I return to the tab in which I'm editing, the cursor works, although it requires hitting enter more than once.


Version: unspecified
Severity: normal
OS: Windows 7
Platform: PC
URL: https://internal.wikia-inc.com/wiki/New_Visual_Editor

Details

Reference
bz37810

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:28 AM
bzimport set Reference to bz37810.

Can you see any JS errors in the debugging console? To access this in Chrome, right-click anywhere on the page, selecting "Inspect element", then in the inspector that pops up at the bottom of the window go to the "Console" tab. If you see any error messages appear there, please post them here.

dbaran wrote:

right, should have done the the first time. Errors as follows:

Uncaught TypeError: Cannot read property 'node' of undefined bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:202
Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:141
2Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:179
Uncaught TypeError: Cannot read property 'node' of undefined bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:202
Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:141
11Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:179
Uncaught TypeError: Cannot read property 'node' of undefined bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:202
Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:141
Uncaught TypeError: Cannot call method 'canHaveChildren' of null bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%7Crangy&skin=vector&version=20120621T210603Z&*:179

Sorry, I should have told you this earlier: could you please set ?debug=true at the end of the URL and try again? That should assign the real line numbers to the errors.

dbaran wrote:

No problemo. Here's the errors with line numbers, and a detailed description of the actions I took:

--loaded editor, placed cursor at end of bullet item (the word "traffic" at the very end of the article)
--clicked away to skype, clicked back to browser with cursor still at end of list item, hit enter. following error resulted:

Uncaught TypeError: Cannot read property 'node' of undefined ve.ce.Surface.js:848

hit enter again, and cursor moved down to beginning of next line, no bullet added. hit backspace to return to previous line, following error resulted:

Uncaught TypeError: Cannot call method 'canHaveChildren' of null ve.dm.Document.js:429

Hit enter again, and cursor didn't move, following error resulted:

Uncaught TypeError: Cannot call method 'canHaveChildren' of null ve.ce.Document.js:21

hit enter a few more times, no cursor movement, and the following same errors:

Uncaught TypeError: Cannot call method 'canHaveChildren' of null ve.ce.Document.js:21
Uncaught TypeError: Cannot call method 'canHaveChildren' of null ve.ce.Document.js:21
Uncaught TypeError: Cannot call method 'canHaveChildren' of null ve.ce.Document.js:21

Mass-moving items into VisualEditor product

orbit wrote:

I committed some fixes for handling at the end of the document, which likely fixed this bug. I'm following the clickstream exactly and am unable to reproduce the problem. Daniel also showed me this bug on his computer, so I have a very good understanding of what the bug looked like.