this seem to have started with 1.20 wmf5.
when selecting "Enable dialogs for inserting links, tables and more" from preferences, the "Advanced" toolbar displays both the "old" buttons (which inject the table and link templates straight into the editbox) sand the "new" ones, i.e. those that open the dialog boxes are visible.

i am 96.12% sure this started with wmf5.

this is very confusing, e.g., both "Table" buttons use the same icon and have the same tooltip ("Table"), yet one of them immediately injects the table wikicode into the textarea, while the 2nd one opens the dialog box - the user has no way to predict how each of the two identical buttons will behave.

the "link" button is also confusing - the icon for "internal link" (which injects [[Link title]]) is almost identical to the one that opens the dialog box for internal/external links.

when enabling the dialob boxes, it's probably best to just hide the "direct injection" buttons, but if it's really desireable to expose both modes, we do need to make them much more distinguishable.

peace.

Version: 1.20.x
Severity: normal