[Regression] WikiEditor 'removeFromToolbar' API is broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Jun 12 2012, 8:12 AM

Description

Steps to reproduce:

Open a page for editing.
Execute (copied from [1]) /* Remove Search & Replace */ $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', { 'section': 'advanced', 'group': 'search', 'tool': 'replace' });

Result in 1.20wmf4: The button for search&replace is removed.
Result in 1.20wmf5: Nothing happens.

https://gerrit.wikimedia.org/r/#/c/9751/ changed the wrapping for buttons from <span> to <a> without changing it in the removeFromToolbar method, too.

[1] https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization#Removing_things

Version: master
Severity: major

Details

Reference: bz37484

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T39346 MediaWiki bugs to be fixed for 1.20wmf5 deployment (tracking)
		Resolved		Krinkle	T39484 [Regression] WikiEditor 'removeFromToolbar' API is broken

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:27 AM

• bzimport added a project: WikiEditor (2010).

• bzimport set Reference to bz37484.

Schnark created this task.Jun 12 2012, 8:12 AM

Raising importance: The API is used internally to replace the icons for <ref>, links and tables with the dialog versions. Since this bug, the icons for simple insertion are not removed, resulting e.g. in two identical looking icons for <ref>.

The icon for signature, which should be suppressed in namespace 0, is shown, too.

I'm not sure why this bug is ignored, so setting importance to Highest.
This is a really annoying bug.

Created attachment 10771
Screenshot

Attached:

Bug 37842 has been marked as a duplicate of this bug. ***

a bugfix (not merged yet) can be found here:
https://gerrit.wikimedia.org/r/#/c/12893/1

(In reply to comment #5)

a bugfix (not merged yet) can be found here:
https://gerrit.wikimedia.org/r/#/c/12893/1

Thank you for that patch. Merged it.

1.20wmf6 was branched and deployed today. The next automatic update window for all extensions is 1.20wmf7, in 2 weeks. I'll see if this can be backported to wmf5 and wmf6. Shouldn't be an issue.

Anyway, marking this fixed.

Bug 29440 has been marked as a duplicate of this bug. ***

happy5214 mentioned this in T39485: Convert ext.wikiEditor.tests.toolbar to QUnit.Nov 25 2014, 11:30 AM

In T39484#418347, @Kipod wrote:

Bug 37842 has been marked as a duplicate of this bug.

Bug 37842 = T39842

In T39484#418387, @TheDJ wrote:

Bug 29440 has been marked as a duplicate of this bug.

Bug 29440 = T31440

GOIII moved this task from Backlog to Closed on the WikiEditor (2010) board.Apr 3 2016, 9:22 AM

	F9459: multiple_buttons.png
	Nov 22 2014, 12:27 AM

[Regression] WikiEditor 'removeFromToolbar' API is brokenClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

[Regression] WikiEditor 'removeFromToolbar' API is broken
Closed, ResolvedPublic
Actions

Related Objects
Search...