Page MenuHomePhabricator
Create Task
Maniphest T41212

CentralNotice banner paging needs to be aware of banner filtering
Closed, ResolvedPublic
Actions

Description

Author: mwalker

Description:
Although the first page of any banner pager view will have the filter applied, moving to any other page (or clicking any link in the pager) will remove the filter.

Somehow we need to inform the pager that it can in fact add an additional GET string to the URI to re-add the filter on page move.

Version: unspecified
Severity: normal

Details

Reference
bz39212

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:07 AM
• bzimport added a project: MediaWiki-extensions-CentralNotice.
• bzimport set Reference to bz39212.
• bzimport created this task.Aug 9 2012, 9:41 PM
Pcoombe added a comment.Oct 24 2013, 4:34 PM

Raising to normal, this is a semi-regular annoyance for me. Probably related to bug 53753

• bzimport added a comment.Jul 30 2014, 9:21 PM

andrew.green.df wrote:

Interestingly, on my local install, the filter remains set when I move from one page to another. But the bug is indeed present as reported on Meta.

CentralNotice stores the last filter value in session data:

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/78f46af3e95aabe94286b6e830a07bbaace685b2/special%2FSpecialCentralNoticeBanners.php#L34

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/78f46af3e95aabe94286b6e830a07bbaace685b2/special%2FSpecialCentralNotice.php#L1522

Maybe something about caching in production gets in the way?

gerritbot added a comment.Aug 4 2014, 1:40 AM

Change 151568 had a related patch set uploaded by AndyRussG:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/151568

gerritbot added a comment.Aug 4 2014, 6:02 PM

Change 151568 merged by jenkins-bot:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/151568

gerritbot added a comment.Aug 20 2014, 7:14 PM

Change 155318 had a related patch set uploaded by Awight:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/155318

gerritbot added a comment.Aug 20 2014, 7:17 PM

Change 155318 merged by Ejegg:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/155318

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL