Page MenuHomePhabricator

Many chained calls in Skins to $this->msg() which doesn't return a value
Closed, ResolvedPublic

Description

Caused by https://gerrit.wikimedia.org/r/#/c/16464/

Fatal error: Call to a member function text() on a non-object in /usr/local/apache/common-local/php-1.20wmf10/skins/CologneBlue.php on line 87

function msg( $str ) {

		echo $this->getMsg( $str )->escaped();

}

function msgHtml( $str ) {

		echo $this->getMsg( $str )->text();

}

function msgWiki( $str ) {

		echo $this->getMsg( $str )->parseAsBlock();

}

110 usages of $this->msg(), many of which then chain something onto it...


Version: 1.20.x
Severity: major

Details

Reference
bz39514

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:00 AM
bzimport set Reference to bz39514.
bzimport added a subscriber: Unknown Object (MLST).