Page MenuHomePhabricator

logs should use the content language and should not depend on the selected user interface
Closed, ResolvedPublic

Description

Author: gangleri

Description:
At http://test.leuksman.com/index.php?title=Main_Page&action=history you can find
(cur) (last) 10:28, May 31, 2005 Gangleri m («Dummy» переименована в «Main Page»)
(cur) (last) 10:26, May 31, 2005 Gangleri m («Main Page» переименована в «Dummy»)

The Russian text means "moved to".

Because the default language of http://test.leuksman.com/ is English all logs
(delete, restore, move etc.) should be in that language.

Best regards

Reinhardt [[user:gangleri]]


Version: unspecified
Severity: normal
URL: http://test.leuksman.com/index.php?title=Main_Page&action=history

Details

Reference
bz2273

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:32 PM
bzimport set Reference to bz2273.

The log appears perfectly normal. The log messages are programmatic, and displayed in
the selected user language in Special:Log.

Are you referring to the comment placed into the page history during move?
If so, please clarify.

gangleri wrote:

The messages can be found in different places:
a) http://test.leuksman.com/index.php/Special:Log/delete

11:35, May 31, 2005 Gangleri restored "Dummy" (5 revisions restored) - 5

revisions restored is in English

11:22, May 31, 2005 Gangleri restored "Dummy" (4 изменений восстановлено) - 4

изменений восстановлено is in Russian
b) same applies to http://test.leuksman.com/index.php/Special:Recentchanges

Main Page was NOT deleted!
c) http://test.leuksman.com/index.php?title=Main_Page&action=history shows three
types of messages for the same action

English:  (cur) (last)  11:33, May 31, 2005 Gangleri m ([[Main Page]] moved

to [[Dummy]])

Russian:  (cur) (last)  11:04, May 31, 2005 Gangleri m ([[Main Page|«Main

Page»]] переименована в [[Dummy|«Dummy»]])

Romanian: (cur) (last)  10:52, May 31, 2005 Gangleri m (Main Page a fost

mutată la Dummy)

The last does not use wikification in [[MediaWiki:1movedto2/ro]].

Dummy was deleted!
d) http://test.leuksman.com/index.php?title=Dummy&action=history

ALL messages are in English - the default language of the wiki. I assume this

is because Dummy was deleted and restored.

I see a problem if languages with RTL writing are used because of rendering.
Imagine you have a history page with Greek, Chinese, Arabic, Cyrillic etc.
messages. My opinion is that both in the history of the page and in the logs all
components MediaWiki messages should use the default language of the wiki.

Best regards Reinhardt

rowan.collins wrote:

The messages in question are *not* generated at run-time, as they are stored as
edit summaries in the database; they should therefore use the "content"
language, not the interface one. Note that this *isn't* a problem with the way
logs work per se, it's just a couple of slip-ups in the code. I've tracked down
at least some of them (sorry, preparing a patch would require more effort than
this seems worth; I'll leave someone with CVS access to make these 3 small edits).

SpecialUndelete.php, line 274:
$reason = wfMsg( 'undeletedrevisions', $restoreRevisions );
should read
$reason = wfMsgForContent( 'undeletedrevisions', $restoreRevisions );

Title.php:
1602: $nullRevision = Revision::newNullRevision( $dbw, $oldid,
1603: wfMsg( '1movedto2', $this->getPrefixedText(),
$nt->getPrefixedText() ),
and
1677: $nullRevision = Revision::newNullRevision( $dbw, $oldid,
1678: wfMsg( '1movedto2', $this->getPrefixedText(),
$nt->getPrefixedText() ),
should either use wfMsgForContent(), or the pre-built variable $comment (which
also includes an additional $reason)

gangleri wrote:

probably an example to comment #3

The title for
http://jadesukka.homelinux.org:8180/betawiki/Project:Portability
is "Betawiki:Portability - Betawiki în română" if I use the Romanian user interface.

The content is definitivly *not* in Romanian.

Regards Reinhardt

gangleri wrote:

the issue described at bug 2314 may relate to this bug
see http://jadesukka.homelinux.org:8180/betawiki/MediaWiki_talk:Summary

it is possible that bug 2114 JavaScript (tracking) depends also on the issue
described at bug 2314

Regards Reinhardt

Commited changes submitted in comment #3. That fix the issue with 1movedto2
and undeletedrevisions revisions.

Probably need a port in 1.4 too.