Page MenuHomePhabricator

Hard coded paths in PremadeMediawikiExtensionGroups::createMessageGroup() reduce flexibility
Closed, ResolvedPublic

Description

This is a regression.

This class is also used for MediaWiki extensions by Wikia, and because of the below code, this cannot be done at the moment without subclassing, which is a bit overdone.

https://gerrit.wikimedia.org/r/#/c/28812/3/ffs/MediaWikiExtensions.php lines 100-101:

$conf['FILES']['sourcePattern'] = "%GROUPROOT%/mediawiki-extensions/extensions/{$info['file']}";
$conf['FILES']['targetPattern'] = "mediawiki-extensions/extensions/{$info['file']}";

Current init code is below. Something similar should remain possible:

$wgHooks['TranslatePostInitGroups'][] = array( 'setupWikia' );
function setupWikia( &$cc, &$deps ) {
global $wgTranslateGroupRoot, $GROUPS;

$def = "$GROUPS/Wikia/extensions.txt";
$path = "$wgTranslateGroupRoot/wikia/";

$foo = new PremadeMediawikiExtensionGroups( $def, $path );
$foo->setNamespace( NS_WIKIA );
$foo->setGroupPrefix( 'wikia-' );
$foo->setUseConfigure( false );
$foo->addAll();

$deps[] = new FileDependency( $def );
return true;
}

For triagers: This would not affect Wikimedia wikis.


Version: master
Severity: normal

Details

Reference
bz41261