Page MenuHomePhabricator

Echo doesn't work on SQLite
Closed, ResolvedPublic

Description

Today Hashar enabled Jenkins tests on the Echo repository, and it failed, so has been disabled.
I did some testing and found that this is because Echo does not work with SQLite, which Jenkins relies on to run the tests.

E.g. this error:
https://integration.mediawiki.org/ci/job/Ext-Echo/20/console
20:32:21 [exec] "CREATE INDEX user_timestamp ON echo_notification (notification_user,notification_timestamp)
20:32:21 [exec] "
20:32:21 [exec] from within function "DatabaseBase::sourceFile( /var/lib/jenkins/jobs/Ext-Echo/workspace/extensions/Echo/echo.sql )".
20:32:21 [exec] Database returned error "1: index user_timestamp already exists"

It also looks like all the files in db_patches/ will fail because of no ALTER TABLE x CHANGE COLUMN. https://www.sqlite.org/omitted.html


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49593

Details

Reference
bz41987

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:56 AM
bzimport set Reference to bz41987.
Krenair created this task.Nov 10 2012, 9:15 PM

bsitu wrote:

Looks like index name in SQLite must be unique across database

Adding schema-change keyword.

Taking this bug.

Another Jenkins test has been activated which causes issues because of this bug - see Gerrit change 40090.

I'm currently fixing Ia2782d64 and I then can prepare the database patch for the Echo index.

Gerrit change 40095.

Please open a new bug for the comment #4 if it's a different issue.

Related URL: https://gerrit.wikimedia.org/r/64594 (Gerrit Change
I9b6468221ba6fe501b15c563f3301694262eec65 )

change merged, tests now run on jenkins

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 19 2017, 8:21 AM